chore: unemojify remaining bk pipelines

ShadowCurse · ShadowCurse · commit e2e15feaf7f3 · 2025-12-09T12:29:54.000Z
Update names for remaining BK pipelines. This
is needed because BK labels are used as a part of
the s3 path where the BK artifacts are uploaded.
Removing emojis and normalizing names simplifies
these paths.

Signed-off-by: Egor Lazarchuk &lt;yegorlz@amazon.co.uk&gt;
diff --git a/.buildkite/common.py b/.buildkite/common.py
@@ -273,7 +273,7 @@ def __init__(self, with_build_step=True, **kwargs):
         if not args.binary_dir and with_build_step:
             build_cmds, self.shared_build = shared_build()
             self.build_group_per_arch(
-                "🏗️ Build", build_cmds, depends_on_build=False, set_key=self.shared_build
+                "build", build_cmds, depends_on_build=False, set_key=self.shared_build
             )
         else:
             self.shared_build = None
diff --git a/.buildkite/pipeline_coverage.py b/.buildkite/pipeline_coverage.py
@@ -9,7 +9,7 @@
 pipeline = BKPipeline(with_build_step=False)
 
 pipeline.build_group(
-    ":coverage: Coverage",
+    "coverage",
     pipeline.devtool_test(
         devtool_opts="--no-build",
         pytest_opts="integration_tests/build/test_coverage.py",
diff --git a/.buildkite/pipeline_cpu_template.py b/.buildkite/pipeline_cpu_template.py
@@ -25,7 +25,7 @@ class BkStep(str, Enum):
         BkStep.COMMAND: [
             "tools/devtool -y test --no-build -- -m no_block_pr -n4 --dist worksteal integration_tests/functional/test_cpu_features_x86_64.py -k 'test_cpu_rdmsr' "
         ],
-        BkStep.LABEL: "📖 rdmsr",
+        BkStep.LABEL: "rdmsr",
         "instances": [
             "m5n.metal",
             "m6i.metal",
@@ -39,7 +39,7 @@ class BkStep(str, Enum):
         BkStep.COMMAND: [
             "tools/devtool -y test --no-build -- -m no_block_pr integration_tests/functional/test_cpu_template_helper.py -k test_guest_cpu_config_change",
         ],
-        BkStep.LABEL: "🖐️ fingerprint",
+        BkStep.LABEL: "fingerprint",
     },
     "cpuid_wrmsr": {
         "snapshot": {
@@ -48,7 +48,7 @@ class BkStep(str, Enum):
                 "mkdir -pv tests/snapshot_artifacts_upload/{instance}_{os}_{kv}",
                 "sudo mv tests/snapshot_artifacts/* tests/snapshot_artifacts_upload/{instance}_{os}_{kv}",
             ],
-            BkStep.LABEL: "📸 create snapshots",
+            BkStep.LABEL: "snapshot-create",
             BkStep.ARTIFACTS: "tests/snapshot_artifacts_upload/**/*",
             BkStep.TIMEOUT: 30,
         },
@@ -58,7 +58,7 @@ class BkStep(str, Enum):
                 "mv tests/snapshot_artifacts_upload/{instance}_{os}_{kv} tests/snapshot_artifacts",
                 "tools/devtool -y test --no-build -- -m nonci -n4 --dist worksteal integration_tests/functional/test_cpu_features_x86_64.py -k 'test_cpu_wrmsr_restore or test_cpu_cpuid_restore'",
             ],
-            BkStep.LABEL: "📸 load snapshot artifacts created on {instance} {snapshot_os} {snapshot_kv} to {restore_instance} {restore_os} {restore_kv}",
+            BkStep.LABEL: "snapshot-restore-src-{instance}-{snapshot_os}-{snapshot_kv}-dst-{restore_instance}-{restore_os}-{restore_kv}",
             BkStep.TIMEOUT: 30,
         },
         "cross_instances": {
@@ -137,7 +137,7 @@ def group_snapshot_restore(test_step):
         )
 
     groups.append(
-        {"group": "📸 restores snapshots", "steps": steps, "depends_on": "snapshot"}
+        {"group": "snapshot-restore", "steps": steps, "depends_on": "snapshot"}
     )
     return groups
 
diff --git a/.buildkite/pipeline_cross.py b/.buildkite/pipeline_cross.py
@@ -36,7 +36,7 @@
         "tar cSvf snapshots/{instance}_{kv}.tar snapshot_artifacts",
     ]
     pipeline.build_group(
-        "📸 create snapshots",
+        "snapshot-create",
         commands,
         timeout=30,
         artifact_paths="snapshots/**/*",
@@ -93,13 +93,13 @@
                     pytest_opts=f"-m nonci -n8 --dist worksteal {k_val} integration_tests/functional/test_snapshot_restore_cross_kernel.py",
                 ),
             ],
-            "label": f"🎬 {src_instance} {src_kv} ➡️ {dst_instance} {dst_kv}",
+            "label": f"snapshot-restore-src-{src_instance}-{src_kv}-dst-{dst_instance}-{dst_kv}",
             "timeout": 30,
             "agents": {"instance": dst_instance, "kv": dst_kv, "os": dst_os},
             **per_instance,
         }
         steps.append(step)
     pipeline.add_step(
-        {"group": "🎬 restore across instances and kernels", "steps": steps}
+        {"group": "snapshot-restore-across-instances-and-kernels", "steps": steps}
     )
     print(pipeline.to_json())
diff --git a/.buildkite/pipeline_docker_popular.py b/.buildkite/pipeline_docker_popular.py
@@ -13,7 +13,7 @@
 ROOTFS_TAR = f"rootfs_$(uname -m)_{random_str(k=8)}.tar.gz"
 
 pipeline.build_group_per_arch(
-    ":ship: Rootfs build",
+    "rootfs-build",
     [
         "sudo yum install -y systemd-container",
         "cd tools/test-popular-containers",
@@ -26,7 +26,7 @@
 )
 
 pipeline.build_group(
-    ":whale: Docker Popular Containers",
+    "docker-popular-containers",
     [
         "./tools/devtool download_ci_artifacts",
         f'buildkite-agent artifact download "{ROOTFS_TAR}" .',
diff --git a/.buildkite/pipeline_pr.py b/.buildkite/pipeline_pr.py
@@ -27,15 +27,15 @@
 pipeline.add_step(
     {
         "command": "./tools/devtool -y checkstyle",
-        "label": "🪶 Style",
+        "label": "style",
     },
     depends_on_build=False,
 )
 
 # run sanity build of devtool if Dockerfile is changed
 if any(x.parent.name == "devctr" for x in changed_files):
     pipeline.build_group_per_arch(
-        "🐋 Dev Container Sanity Build",
+        "dev-container-sanity-build",
         "./tools/devtool -y build_devctr && DEVCTR_IMAGE_TAG=latest ./tools/devtool test --no-build -- integration_tests/functional/test_api.py",
     )
 
@@ -44,7 +44,7 @@
     for x in changed_files
 ):
     pipeline.build_group_per_arch(
-        "📦 Release Sanity Build",
+        "release-sanity-build",
         "./tools/devtool -y make_release",
         depends_on_build=False,
     )
@@ -56,7 +56,7 @@
     or any(x.name == "test_kani.py" for x in changed_files)
 ):
     kani_grp = pipeline.build_group(
-        "🔍 Kani",
+        "kani",
         "./tools/devtool -y test --no-build -- ../tests/integration_tests/test_kani.py -n auto",
         # Kani step default
         # Kani runs fastest on m6a.metal
@@ -66,26 +66,23 @@
         **DEFAULTS_PERF,
         depends_on_build=False,
     )
-    # modify Kani steps' label
-    for step in kani_grp["steps"]:
-        step["label"] = "🔍 Kani"
 
 if run_all_tests(changed_files):
     pipeline.build_group(
-        "📦 Build",
+        "build",
         pipeline.devtool_test(pytest_opts="integration_tests/build/"),
         depends_on_build=False,
     )
 
     pipeline.build_group(
-        "⚙ Functional and security 🔒",
+        "functional-and-security",
         pipeline.devtool_test(
             pytest_opts="-n 16 --dist worksteal integration_tests/{{functional,security}}",
         ),
     )
 
     pipeline.build_group(
-        "⏱ Performance",
+        "performance",
         pipeline.devtool_test(
             devtool_opts="--performance -c 1-10 -m 0",
             pytest_opts="../tests/integration_tests/performance/",
diff --git a/.buildkite/pipeline_pr_no_block.py b/.buildkite/pipeline_pr_no_block.py
@@ -19,7 +19,7 @@
 )
 
 pipeline.build_group(
-    "❓ Optional",
+    "optional",
     pipeline.devtool_test(
         devtool_opts="--performance -c 1-10 -m 0",
         pytest_opts="integration_tests/ -m no_block_pr --log-cli-level=INFO",
diff --git a/.buildkite/pipeline_release_qa.py b/.buildkite/pipeline_release_qa.py
@@ -14,7 +14,7 @@
 
 pipeline.add_step(
     {
-        "label": "Download release",
+        "label": "download-release",
         "if": 'build.env("VERSION") != "dev"',
         "command": [
             "aws s3 sync --no-sign-request s3://spec.ccfc.min/firecracker-ci/firecracker/$$VERSION release-$$VERSION",
@@ -25,7 +25,7 @@
 )
 
 pipeline.build_group_per_arch(
-    ":building_construction: Make release",
+    "make-release",
     # if is a keyword for python, so we need this workaround to expand it as a kwarg
     **{"if": 'build.env("VERSION") == "dev"'},
     command=[
@@ -48,7 +48,7 @@
 # The devtool expects the examples to be in the same folder as the binaries to run some tests
 # (for example, uffd handler tests). Build them and upload them in the same folder.
 pipeline.build_group_per_arch(
-    ":hammer_and_wrench: Build examples",
+    "build-examples",
     command=[
         "CARGO_TARGET=$$(uname -m)-unknown-linux-musl",
         "./tools/devtool -y sh cargo build --target $$CARGO_TARGET --release --examples",
@@ -63,7 +63,7 @@
 
 pipeline.add_step(
     {
-        "label": ":pipeline: PR",
+        "label": "pr",
         "command": (
             ".buildkite/pipeline_pr.py --binary-dir release-$$VERSION "
             "| jq '(..|select(.priority? != null).priority) += 100' "

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ def __init__(self, with_build_step=True, **kwargs):`
`273`	`273`	`if not args.binary_dir and with_build_step:`
`274`	`274`	`build_cmds, self.shared_build = shared_build()`
`275`	`275`	`self.build_group_per_arch(`
`276`		`- "🏗️ Build", build_cmds, depends_on_build=False, set_key=self.shared_build`
	`276`	`+ "build", build_cmds, depends_on_build=False, set_key=self.shared_build`
`277`	`277`	`)`
`278`	`278`	`else:`
`279`	`279`	`self.shared_build = None`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`ROOTFS_TAR = f"rootfs_$(uname -m)_{random_str(k=8)}.tar.gz"`
`14`	`14`
`15`	`15`	`pipeline.build_group_per_arch(`
`16`		`- ":ship: Rootfs build",`
	`16`	`+ "rootfs-build",`
`17`	`17`	`[`
`18`	`18`	`"sudo yum install -y systemd-container",`
`19`	`19`	`"cd tools/test-popular-containers",`
`@@ -26,7 +26,7 @@`
`26`	`26`	`)`
`27`	`27`
`28`	`28`	`pipeline.build_group(`
`29`		`- ":whale: Docker Popular Containers",`
	`29`	`+ "docker-popular-containers",`
`30`	`30`	`[`
`31`	`31`	`"./tools/devtool download_ci_artifacts",`
`32`	`32`	`f'buildkite-agent artifact download "{ROOTFS_TAR}" .',`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`)`
`20`	`20`
`21`	`21`	`pipeline.build_group(`
`22`		`- "❓ Optional",`
	`22`	`+ "optional",`
`23`	`23`	`pipeline.devtool_test(`
`24`	`24`	`devtool_opts="--performance -c 1-10 -m 0",`
`25`	`25`	`pytest_opts="integration_tests/ -m no_block_pr --log-cli-level=INFO",`