[1.x & 2.x] common/components/AlertAlertAttrs: `ondismiss` won't be triggered

[zDaleZ]

Current Behavior

Even if an ondismiss function and dismissible: true are specified, closing alert doesn't trigger that function.

It's a long-existed bug, since flarum-pwa uses this to remember user's preference, not to notify user to enable push notification - the result is the extension always show alerts, even if user has closed alerts before.

Steps to Reproduce

Just paste the code below into the console. After closing the alert, you'll easily find the alert() doesn't run.

app.alerts.show({
    dissmissible: true,
    ondismiss: ()=>alert('dismissed')
}, 'test');

Expected Behavior

ondismiss function should be called.

Screenshots

No response

Environment

• Flarum version: 1.x & 2.x latest version
• Website URL: N/A
• Webserver: N/A
• Hosting environment: N/A
• PHP version: N/A
• Browser: Seems happens on all browsers

Output of php flarum info

No response

Possible Solution

No response

Additional Context

No response

[imorland]

Thanks for the report, and for the clear repro — that made this quick to confirm.

Fixed for 2.x in #4899. AlertManager was spreading the alert's attrs and then overwriting ondismiss with its own dismiss handler, so any callback passed to app.alerts.show() was discarded before Alert ever saw it. It now runs your callback and then dismisses the alert.

On 1.x — you're right that the same code is there, so the bug is real on both. 1.x is in critical-fixes-only maintenance now though, so this one is landing on 2.x only.