FnCLI fn deploy

Author: Jaytee-fn

common/common.go

@@ -55,6 +55,7 @@ const (
 	MinRequiredDockerVersion = "17.5.0"
 	BuildxBuilderInstance    = "oci_fn_builder"
 	DefaultAppShape          = modelsv2.AppShapeGENERICX86
+	ContainerEngineType      = "docker"
 )
 
 var GlobalVerbose bool
@@ -435,7 +436,6 @@ func buildXDockerCommand(imageName, dockerfile string, buildArgs []string, noCac
 		var label = "imageName=" + imageName
 		args = append(args, "--build-arg", arg)
 		args = append(args, "--label", label)
-		args = append(args, "--push")
 	}
 
 	args = append(args,
@@ -515,10 +515,12 @@ func RunBuild(verbose bool, dir, imageName, dockerfile string, buildArgs []strin
 		var mappedArchitectures []string
 		if arch, ok := ShapeMap[shape]; ok {
 			mappedArchitectures = append(mappedArchitectures, arch...)
-			err := initializeContainerBuilder(containerEngineType, mappedArchitectures)
-			if err != nil {
-				done <- err
-				return
+			if containerEngineType == ContainerEngineType {
+				err := initializeContainerBuilder(containerEngineType, mappedArchitectures)
+				if err != nil {
+					done <- err
+					return
+				}
 			}
 
 			dockerBuildCmdArgs = buildXDockerCommand(imageName, dockerfile, buildArgs, noCache, mappedArchitectures)
@@ -551,6 +553,15 @@ func RunBuild(verbose bool, dir, imageName, dockerfile string, buildArgs []strin
 		fmt.Fprintln(os.Stderr)
 		return fmt.Errorf("build cancelled on signal %v", signal)
 	}
+	// Push to docker registry
+	fmt.Println("Using Container engine", containerEngineType, "to push")
+	fmt.Printf("Pushing %v to docker registry...", imageName)
+	cmd := exec.Command(containerEngineType, "push", imageName)
+	cmd.Stderr = os.Stderr
+	cmd.Stdout = os.Stdout
+	if err := cmd.Run(); err != nil {
+		return fmt.Errorf("error running %v push, are you logged?: %v", containerEngineType, err)
+	}
 	return nil
 }