Skip to content

Commit 68d8027

Browse files
committed
docs: improve integration_test.template.sh
1 parent 1c0efce commit 68d8027

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

templates/integration_test.template.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
set -eEuo pipefail
33
cd "$(dirname "$(readlink -f "$0")")"
44

5-
FIXME BASH_BUDDY_ROOT=/path/to/bash_buddy/dir
5+
FIXME BASH_BUDDY_ROOT="$(readlink -f path/to/bash-buddy/dir)"
6+
readonly BASH_BUDDY_ROOT
67

78
source "$BASH_BUDDY_ROOT/lib/trap_error_info.sh"
89
source "$BASH_BUDDY_ROOT/lib/common_utils.sh"
@@ -27,28 +28,28 @@ source "$BASH_BUDDY_ROOT/lib/java_build_utils.sh"
2728
# ci build logic
2829
################################################################################
2930

30-
FIXME PROJECT_ROOT_DIR=/path/to/project/root/dir
31+
FIXME PROJECT_ROOT_DIR="$(readlink -f /path/to/project/root/dir)"
3132
cd "$PROJECT_ROOT_DIR"
3233

3334
########################################
34-
# default jdk 11, do build and test
35+
# do build and test by default version jdk
3536
########################################
3637

3738
prepare_jdks::switch_to_jdk "$default_build_jdk_version"
3839

39-
cu::head_line_echo "build and test with Java: $JAVA_HOME"
40+
cu::head_line_echo "build and test with JDK: $JAVA_HOME"
4041
jvb::mvn_cmd clean install
4142

4243
########################################
43-
# test multi-version java
44+
# test by multi-version jdk
4445
########################################
4546
for jdk in "${PREPARE_JDKS_INSTALL_BY_SDKMAN[@]}"; do
46-
# already tested by above `mvn install`
47+
# already tested above
4748
[ "$jdk" = "$default_build_jdk_version" ] && continue
4849

4950
prepare_jdks::switch_to_jdk "$jdk"
5051

51-
cu::head_line_echo "test with Java: $JAVA_HOME"
52+
cu::head_line_echo "test with JDK: $JAVA_HOME"
5253
# just test without build
5354
jvb::mvn_cmd surefire:test
5455
done

0 commit comments

Comments
 (0)