fix: keep ended promotions terminal

Author: fuller-stack-dev

convex/promotions.test.ts

@@ -307,6 +307,22 @@ describe("promotions.setStatus", () => {
     expect(patches).toHaveLength(0);
     expect(inserts).toHaveLength(0);
   });
+
+  it("rejects reactivating an ended promotion", async () => {
+    vi.mocked(requireUser).mockResolvedValue({
+      userId: adminUser._id,
+      user: adminUser,
+    } as never);
+    const { ctx, inserts, patches } = makeMutationCtx({
+      existing: { ...storedPromotion, status: "ended" },
+    });
+
+    await expect(
+      setStatusHandler(ctx, { slug: validInput.slug, status: "active" }),
+    ).rejects.toThrow(/reactivated/);
+    expect(patches).toHaveLength(0);
+    expect(inserts).toHaveLength(0);
+  });
 });
 
 describe("promotions.listForStaff", () => {

convex/promotions.ts

@@ -311,6 +311,9 @@ async function setPromotionStatusForActor(
   if (existing.status === "draft" && status === "ended") {
     throw new ConvexError("Draft promotions must be activated before they can end");
   }
+  if (existing.status === "ended" && status === "active") {
+    throw new ConvexError("Ended promotions cannot be reactivated");
+  }
   if (existing.status === status) {
     return { ok: true as const, slug: existing.slug, status };
   }

src/routes/-management/PromotionsPage.test.tsx

@@ -98,4 +98,17 @@ describe("PromotionsPage", () => {
     fireEvent.click(screen.getByRole("button", { name: "Load more" }));
     expect(onLoadMore).toHaveBeenCalledOnce();
   });
+
+  it("does not offer to reactivate ended promotions", () => {
+    render(
+      <PromotionsPage
+        promotions={[makePromotion({ status: "ended" })]}
+        onCreate={vi.fn()}
+        onUpdate={vi.fn()}
+        onSetStatus={vi.fn()}
+      />,
+    );
+
+    expect(screen.queryByRole("button", { name: "Activate" })).toBeNull();
+  });
 });

src/routes/-management/PromotionsPage.tsx

@@ -261,7 +261,7 @@ export function PromotionsPage({
                 >
                   Edit
                 </Button>
-                {promotion.status !== "active" ? (
+                {promotion.status === "draft" ? (
                   <Button
                     className="management-action-btn"
                     type="button"