cli: Temporarily disable the large index deletion check (#43091)

GitOrigin-RevId: 8c113c9a5396cb0b657cacc194fb379c5db54472

Author: Nicolapps

src/cli/lib/checkForLargeIndexDeletion.ts

@@ -90,10 +90,9 @@ export async function checkForLargeIndexDeletion({
     }),
   );
 
-  const minDocumentsForWarning = minDocumentsForIndexDeleteWarning();
   if (
     !deletedIndexesWithDocumentsCount.some(
-      ({ count }) => count >= minDocumentsForWarning,
+      ({ count }) => count >= MIN_DOCUMENTS_FOR_INDEX_DELETE_WARNING,
     )
   ) {
     logFinishedStep("No large indexes are deleted by this push");
@@ -105,13 +104,12 @@ from your production deployment (${options.url}):
 
 ${deletedIndexesWithDocumentsCount
   .map(({ componentDefinitionPath, index, count }) =>
-    formatDeletedIndex({
+    formatDeletedIndex(
       componentDefinitionPath,
       index,
-      indexDiff: indexDiffs[componentDefinitionPath],
-      documentsCount: count,
-      minDocumentsForWarning,
-    }),
+      indexDiffs[componentDefinitionPath],
+      count,
+    ),
   )
   .join("\n")}
 
@@ -153,26 +151,19 @@ to be backfilled again if you want to restore it later.
   logFinishedStep("Proceeding with push.");
 }
 
-function formatDeletedIndex({
-  componentDefinitionPath,
-  index,
-  indexDiff,
-  documentsCount,
-  minDocumentsForWarning,
-}: {
-  componentDefinitionPath: string;
-  index: DeveloperIndexConfig;
-  indexDiff: IndexDiff;
-  documentsCount: number;
-  minDocumentsForWarning: number;
-}) {
+function formatDeletedIndex(
+  componentDefinitionPath: string,
+  index: DeveloperIndexConfig,
+  indexDiff: IndexDiff,
+  documentsCount: number,
+) {
   const componentNameFormatted =
     componentDefinitionPath !== ""
       ? `${chalk.gray(componentDefinitionPath)}:`
       : "";
 
   const documentsCountFormatted =
-    documentsCount >= minDocumentsForWarning
+    documentsCount >= MIN_DOCUMENTS_FOR_INDEX_DELETE_WARNING
       ? `  ${chalk.yellowBright(`⚠️  ${documentsCount.toLocaleString()} documents`)}`
       : `  ${documentsCount.toLocaleString()} ${documentsCount === 1 ? "document" : "documents"}`;
 
@@ -194,14 +185,3 @@ function getTableName(index: DeveloperIndexConfig) {
   const [tableName, _indexName] = index.name.split(".");
   return tableName;
 }
-
-function minDocumentsForIndexDeleteWarning(): number {
-  const envValue = process.env.CONVEX_MIN_DOCUMENTS_FOR_INDEX_DELETE_WARNING;
-  if (envValue !== undefined) {
-    const parsed = parseInt(envValue, 10);
-    if (!isNaN(parsed)) {
-      return parsed;
-    }
-  }
-  return MIN_DOCUMENTS_FOR_INDEX_DELETE_WARNING;
-}

src/cli/lib/components.ts

@@ -54,7 +54,6 @@ import { DEFINITION_FILENAME_TS } from "./components/constants.js";
 import { DeploymentSelection } from "./deploymentSelection.js";
 import { deploymentDashboardUrlPage } from "./dashboard.js";
 import { formatIndex, LargeIndexDeletionCheck } from "./indexes.js";
-import { checkForLargeIndexDeletion } from "./checkForLargeIndexDeletion.js";
 import { LogManager } from "./logs.js";
 
 export type PushOptions = {
@@ -366,19 +365,6 @@ async function startComponentsPushAndCodegen(
   }
   logStartPushSizes(parentSpan, startPushRequest);
 
-  if (options.largeIndexDeletionCheck !== "no verification") {
-    await parentSpan.enterAsync("checkForLargeIndexDeletion", (span) =>
-      checkForLargeIndexDeletion({
-        ctx,
-        span,
-        request: startPushRequest,
-        options,
-        askForConfirmation:
-          options.largeIndexDeletionCheck === "ask for confirmation",
-      }),
-    );
-  }
-
   changeSpinner("Uploading functions to Convex...");
   const startPushResponse = await parentSpan.enterAsync("startPush", (span) =>
     startPush(ctx, span, startPushRequest, options),