From 211fe3bc26e10d716c3074bcb47b7b595345db8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C5=82a=C5=BCej=20Che=C5=82kowski?= Date: Tue, 24 Mar 2026 23:32:07 +0100 Subject: [PATCH] fix: remove redundant ROKU_DEV_USER --- README.md | 1 - commands/package.js | 2 -- commands/screenshot.js | 2 -- commands/start.js | 2 -- commands/test.js | 2 -- options/rokuDevUser.js | 5 ----- schematics/lib/new/files/README.md | 1 - schematics/lib/new/new.factory.js | 1 - schematics/lib/new/schema.json | 5 ----- 9 files changed, 21 deletions(-) delete mode 100644 options/rokuDevUser.js diff --git a/README.md b/README.md index 0c069f9..795b922 100644 --- a/README.md +++ b/README.md @@ -38,7 +38,6 @@ kopytko --help kopytko --help ``` - | Command | Alias | Description | |:----------:|:-----:|----------------------------------------------------------| | screenshot | sc | Takes a screenshot of current application | diff --git a/commands/package.js b/commands/package.js index ec5a1d0..73124b0 100644 --- a/commands/package.js +++ b/commands/package.js @@ -1,7 +1,6 @@ const rokuDevSigningPasswordOption = require('../options/rokuDevSigningPassword'); const signedPackagePathOption = require('../options/signedPackagePath'); const rokuDevPasswordOption = require('../options/rokuDevPassword'); -const rokuDevUserOption = require('../options/rokuDevUser'); const forceHttpOption = require('../options/forceHttp'); const rokuDevIdOption = require('../options/rokuDevId'); const rokuIPOption = require('../options/rokuIP'); @@ -16,7 +15,6 @@ function load(program) { .addOption(envOption) .addOption(rokuIPOption) .addOption(rokuDevIdOption) - .addOption(rokuDevUserOption) .addOption(rokuDevPasswordOption) .addOption(rokuDevSigningPasswordOption) .addOption(signedPackagePathOption) diff --git a/commands/screenshot.js b/commands/screenshot.js index cabc061..ea48ef3 100644 --- a/commands/screenshot.js +++ b/commands/screenshot.js @@ -1,5 +1,4 @@ const rokuDevPasswordOption = require('../options/rokuDevPassword'); -const rokuDevUserOption = require('../options/rokuDevUser'); const rokuIPOption = require('../options/rokuIP'); function load(program) { @@ -8,7 +7,6 @@ function load(program) { .alias('sc') .description('Takes a screenshot of the dev application') .addOption(rokuIPOption) - .addOption(rokuDevUserOption) .addOption(rokuDevPasswordOption) .action(() => { try { diff --git a/commands/start.js b/commands/start.js index a457ca4..3c6247f 100644 --- a/commands/start.js +++ b/commands/start.js @@ -1,5 +1,4 @@ const rokuDevPasswordOption = require('../options/rokuDevPassword'); -const rokuDevUserOption = require('../options/rokuDevUser'); const forceHttpOption = require('../options/forceHttp'); const rokuIPOption = require('../options/rokuIP'); const telnetOption = require('../options/telnet'); @@ -12,7 +11,6 @@ function load(program) { .description('Compiles and runs an application on a Roku device') .addOption(envOption) .addOption(rokuIPOption) - .addOption(rokuDevUserOption) .addOption(rokuDevPasswordOption) .addOption(forceHttpOption) .addOption(telnetOption) diff --git a/commands/test.js b/commands/test.js index 292dd05..2ef2f2d 100644 --- a/commands/test.js +++ b/commands/test.js @@ -1,6 +1,5 @@ const rokuDevPasswordOption = require('../options/rokuDevPassword'); const testFileNameOption = require('../options/testFileName'); -const rokuDevUserOption = require('../options/rokuDevUser'); const forceConnectOption = require('../options/forceConnect'); const forceHttpOption = require('../options/forceHttp'); const rokuIPOption = require('../options/rokuIP'); @@ -12,7 +11,6 @@ function load(program) { .alias('t') .description('Compiles and runs unit tests on a Roku device') .addOption(rokuIPOption) - .addOption(rokuDevUserOption) .addOption(rokuDevPasswordOption) .addOption(testFileNameOption) .addOption(telnetOption) diff --git a/options/rokuDevUser.js b/options/rokuDevUser.js deleted file mode 100644 index 2532885..0000000 --- a/options/rokuDevUser.js +++ /dev/null @@ -1,5 +0,0 @@ -const { Option } = require('commander'); - -module.exports = new Option('--rokuDevUser ', 'Roku developer username') - .default('rokudev') - .env('ROKU_DEV_USER'); diff --git a/schematics/lib/new/files/README.md b/schematics/lib/new/files/README.md index ad03e4f..0d83772 100644 --- a/schematics/lib/new/files/README.md +++ b/schematics/lib/new/files/README.md @@ -20,7 +20,6 @@ You can change predefined configuration inside `.env` file: ``` ROKU_IP= -ROKU_DEV_USER= ROKU_DEV_PASSWORD= ROKU_DEV_ID= diff --git a/schematics/lib/new/new.factory.js b/schematics/lib/new/new.factory.js index 86b9138..391c65a 100644 --- a/schematics/lib/new/new.factory.js +++ b/schematics/lib/new/new.factory.js @@ -25,7 +25,6 @@ function createEnvFile(options, path) { return (tree) => { tree.create(path + '/.env', ` ROKU_IP=${options.rokuIP} -ROKU_DEV_USER=${options.rokuDevUser} ROKU_DEV_PASSWORD=${options.rokuDevPassword} ROKU_DEV_ID=${options.rokuDevId} diff --git a/schematics/lib/new/schema.json b/schematics/lib/new/schema.json index 6a99e3b..7eac709 100644 --- a/schematics/lib/new/schema.json +++ b/schematics/lib/new/schema.json @@ -9,11 +9,6 @@ "default": "", "x-prompt": "What is your Roku device IP address?" }, - "rokuDevUser": { - "type": "string", - "default": "rokudev", - "x-prompt": "What is your Roku device dev user?" - }, "rokuDevPassword": { "type": "string", "default": "",