fix(ci): re-pin ffmpeg on a month-end BtbN build - #295
Merged
Conversation
autobuild-2026-07-30-13-32 is a Thursday daily. BtbN keeps roughly 15 days of dailies and prunes the rest, retaining only month-end builds long term, so the pin was due to 404 around 2026-08-14. When it does, fetch:ffmpeg fails before cargo, taking build:linux and build:win with it — and publish-release needs both. This is the second occurrence: 81e0597 re-pinned after autobuild-2026-07-15-14-01 was purged the same way. The header comment called the tag "immutable", which is true and beside the point; it now states the retention rule and how to check it. Re-pinned to autobuild-2026-07-31-14-10 (n8.1.2-34-g9b6c8969e0), the last day of July. Tag, asset names and digests move as one unit: 4 PINNED plus 3 SHARED_PINNED entries, plus the three places that name the ffmpeg source commit so the LGPL source offer keeps pointing at the binaries we ship.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesFFmpeg release update
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/fetch-ffmpeg.mjswas pinned toautobuild-2026-07-30-13-32— a Thursday daily autobuild. BtbN keeps only ~15 days of dailies and prunes the rest, retaining month-end builds long term. The pin was due to 404 around 2026-08-14.When it 404s,
npm run fetch:ffmpeg*throws (downloadAndExtracthas no retry and no fallback), sobuild:linuxandbuild:windie before cargo — andpublish-releasehas both inneeds:. No release, any platform.Evidence for the retention rule:
Nothing between 2026-07-23 and 2026-06-30 survives, and every older tag is a last-day-of-month build.
This is the second occurrence — 81e0597 re-pinned after
autobuild-2026-07-15-14-01was purged the same way. The header comment described the tag as "immutable", which is true and beside the point; it now states the retention rule and thegh apione-liner to check a candidate.Re-pinned to
autobuild-2026-07-31-14-10(n8.1.2-34-g9b6c8969e0), the last day of July, still a release-branch 8.1.x build — not anN-…master snapshot.Tag, asset names and digests move as one unit, so the diff covers all four places that name them:
scripts/fetch-ffmpeg.mjsRELEASE_TAG, 4PINNED+ 3SHARED_PINNEDentries (asset + sha256), retention rule in the header commentTHIRD-PARTY-NOTICES.mdcrates/.cargo/config.tomltechnical-documentation/architecture/native-compositor.mdRelated issue
No issue — found while auditing the Linux build/packaging chain.
Type of change
Release impact
Desktop impact
Screenshots / video
n/a
Testing
npm run fetch:ffmpegon Ubuntu 24.04 x86_64, against a cleanedelectron/native/bin/linux-x64/, exit 0:Both digests verified against the release's own
checksums.sha256, and the script's own SHA-256 gate then re-verified them on the downloaded bytes. The Windows and arm64 digests come from the same file; they are not exercised by this run and will be by the first CI build.Note for #293
That PR adds a
linux-arm64entry toSHARED_PINNEDand will conflict here. Its digest at this tag is:🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Documentation