From 185ec37c4818bd33e3e473e464c14a034d963e3f Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Fri, 17 Jul 2026 10:50:51 +0200 Subject: [PATCH] build: require C++17 for `crashpad_client` consumers The Sentry-maintained CMake metadata for `crashpad_client` still advertised `cxx_std_14`, but the headers it installs and exposes use C++17 library types such as `std::optional` and `std::string_view`. That lets CMake consumers compile against those headers with an insufficient language standard. Update the exported usage requirement to `cxx_std_17` so the CMake build stays in sync with the upstream Crashpad source requirements. This does not raise sentry-native's effective Crashpad requirement: Crashpad already sets `CMAKE_CXX_STANDARD` to `17` with `CMAKE_CXX_STANDARD_REQUIRED` enabled, and sentry-native documents the Crashpad backend as requiring a C++17-compatible compiler. --- client/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/CMakeLists.txt b/client/CMakeLists.txt index cf1d3a07c..eb60defa7 100644 --- a/client/CMakeLists.txt +++ b/client/CMakeLists.txt @@ -75,7 +75,7 @@ target_link_libraries(crashpad_client crashpad_util mini_chromium ) -target_compile_features(crashpad_client PUBLIC cxx_std_14) +target_compile_features(crashpad_client PUBLIC cxx_std_17) set_property(TARGET crashpad_client PROPERTY EXPORT_NAME client) add_library(crashpad::client ALIAS crashpad_client)