refactor(nextjs): Change ESM interop. to remove lazy loading (#22193)

Code checking `default` like this always points to an ESM/CJS interop
issue:

https://github.com/getsentry/sentry-javascript/blob/8c6358a31de99cdb697509e4e2b1fcc38efba401/packages/server-utils/src/orchestrion/bundler/webpack.ts#L53

This is caused by our repo-wide Rollup setting of `interop: 'esModule'`.
This is required for us to be able to monkey patch Node built-ins but
causes the above issues with CJS dependencies that use the classic CJS
default export (`module.exports = fn`).

This PR overrides the `interop` setting for the suspect package and
removes the lazy dependency loading.

Author: timfish

dev-packages/rollup-utils/npmHelpers.mjs

@@ -94,6 +94,11 @@ export function makeBaseNPMConfig(options = {}) {
       // (We don't need it, so why waste the bytes?)
       freeze: false,
 
+      // Assume externals are ESM-shaped (`__esModule` + `.default`), which our own `@sentry/*`
+      // packages satisfy via `esModule: 'if-default-prop'`. This keeps `import * as x` a live
+      // reference to the real module rather than an `_interopNamespace` copy — instrumentation code
+      // relies on that to monkey-patch modules like `fs` in place. Packages that pull in bare-CJS
+      // third-party deps (no `.default`) override this per-module (see server-utils).
       interop: 'esModule',
     },
 

packages/nextjs/src/config/webpack.ts

@@ -433,7 +433,7 @@ export function constructWebpackConfigFunction({
 
     // Orchestrion code-transform loader — Node server runtime only, never the edge compilation
     if (runtime === 'server' && userSentryOptions._experimental?.useDiagnosticsChannelInjection) {
-      newConfig.plugins.push(sentryOrchestrionWebpackPlugin() as WebpackPluginInstance);
+      newConfig.plugins.push(sentryOrchestrionWebpackPlugin() as unknown as WebpackPluginInstance);
     }
 
     return newConfig;

packages/server-utils/rollup.npm.config.mjs

@@ -44,6 +44,14 @@ export default [
           exports: 'named',
           // set preserveModules to true because we don't want to bundle everything into one file.
           preserveModules: true,
+          // `@apm-js-collab/code-transformer-bundler-plugins` ships CJS entries as bare
+          // `module.exports = fn` with no `__esModule`/`.default`. The repo default
+          // `interop: 'esModule'` assumes ESM-shaped externals and would dereference a nonexistent
+          // `.default`, so a default import compiles to `codeTransformer.default(...)` → "not a
+          // function". Use 'auto' for just these so Rollup emits its interop helper. Scoped here (not
+          // repo-wide) because 'auto' also turns `import * as x` into a copy, which breaks in-place
+          // monkey-patching that other packages (e.g. the OTel fs instrumentation) depend on.
+          interop: id => (id?.startsWith('@apm-js-collab/code-transformer-bundler-plugins') ? 'auto' : 'esModule'),
         },
       },
     }),

packages/server-utils/src/orchestrion/bundler/webpack.ts

@@ -5,6 +5,7 @@ import { createRequire } from 'node:module';
 import { dirname } from 'node:path';
 import type { InstrumentationConfig } from '..';
 import { SENTRY_INSTRUMENTATIONS } from '../config';
+import codeTransformerWebpack from '@apm-js-collab/code-transformer-bundler-plugins/webpack';
 import type { PluginOptions } from './options';
 import { orchestrionTransformOptions } from './options';
 
@@ -46,10 +47,6 @@ export function getSentryInstrumentations(): InstrumentationConfig[] {
 /**
  * The code-transform webpack plugin, pre-fed the instrumentation config
  */
-export function sentryOrchestrionWebpackPlugin(options: PluginOptions = {}): unknown {
-  const mod = getOrchestrionRequire()('@apm-js-collab/code-transformer-bundler-plugins/webpack') as {
-    default?: (options: { instrumentations: InstrumentationConfig[] }) => unknown;
-  };
-  const codeTransformerWebpack = mod.default ?? (mod as unknown as NonNullable<typeof mod.default>);
+export function sentryOrchestrionWebpackPlugin(options: PluginOptions = {}): ReturnType<typeof codeTransformerWebpack> {
   return codeTransformerWebpack(orchestrionTransformOptions(options));
 }