feat(core): Default span status to ok in transaction mode (#22521)

We do this in node via opentelemetry span processing today, so if we
remove this processing a bunch of tests fail for node which rely on span
status being OK. I figured this makes sense and likely is more or less
the same if this is ok or unset for a span, and also aligns with span
streaming 🤔

Author: mydea

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone-mixed-transaction/test.ts

@@ -76,6 +76,7 @@ sentryTest(
       segment_id: transactionEnvelopeItem.contexts?.trace?.span_id,
       parent_span_id: parentSpanId,
       origin: 'manual',
+      status: 'ok',
       span_id: expect.stringMatching(/[a-f\d]{16}/),
       start_timestamp: expect.any(Number),
       timestamp: expect.any(Number),
@@ -91,6 +92,7 @@ sentryTest(
             'sentry.source': 'custom',
           },
           origin: 'manual',
+          status: 'ok',
           span_id: parentSpanId,
           trace_id: traceId,
         },
@@ -110,6 +112,7 @@ sentryTest(
           },
           description: 'inner',
           origin: 'manual',
+          status: 'ok',
           parent_span_id: parentSpanId,
           span_id: expect.stringMatching(/[a-f\d]{16}/),
           start_timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/public-api/startSpan/standalone/test.ts

@@ -48,6 +48,7 @@ sentryTest('sends a segment span envelope', async ({ getLocalTestUrl, page }) =>
     },
     description: 'standalone_segment_span',
     origin: 'manual',
+    status: 'ok',
     span_id: expect.stringMatching(/^[\da-f]{16}$/),
     start_timestamp: expect.any(Number),
     timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/backgroundtab-custom/test.ts

@@ -19,7 +19,7 @@ sentryTest('should finish a custom transaction when the page goes background', a
   const status_before = spanJsonBefore.status;
 
   expect(description_before).toBe('test-span');
-  expect(status_before).toBeUndefined();
+  expect(status_before).toBe('ok');
 
   await page.locator('#go-background').click();
   const spanJsonAfter: SpanJSON = await page.evaluate('window.getSpanJson()');

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/multiple-redirects/test.ts

@@ -64,6 +64,7 @@ sentryTest(
         description: expect.stringContaining('/sub-page-redirect-'),
         op: 'navigation.redirect',
         origin: 'auto.navigation.browser',
+        status: 'ok',
         parent_span_id: pageloadRequest.contexts!.trace!.span_id,
         span_id: expect.any(String),
         start_timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/pageload-redirect/test.ts

@@ -60,6 +60,7 @@ sentryTest('creates a pageload root span with navigation.redirect childspan', as
     description: '/sub-page',
     op: 'navigation.redirect',
     origin: 'auto.navigation.browser',
+    status: 'ok',
     parent_span_id: pageloadRequest.contexts!.trace!.span_id,
     span_id: expect.any(String),
     start_timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts

@@ -110,6 +110,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
     description: 'https://sentry-test-site.example/path/to/image.svg',
     op: 'resource.img',
     origin: 'auto.resource.browser.metrics',
+    status: 'ok',
     parent_span_id: spanId,
     span_id: expect.stringMatching(/^[a-f\d]{16}$/),
     start_timestamp: expect.any(Number),
@@ -158,6 +159,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
     description: 'https://sentry-test-site.example/path/to/style.css',
     op: 'resource.link',
     origin: 'auto.resource.browser.metrics',
+    status: 'ok',
     parent_span_id: spanId,
     span_id: expect.stringMatching(/^[a-f\d]{16}$/),
     start_timestamp: expect.any(Number),
@@ -200,6 +202,7 @@ sentryTest('adds resource spans to pageload transaction', async ({ getLocalTestU
     description: 'https://sentry-test-site.example/path/to/script.js',
     op: 'resource.script',
     origin: 'auto.resource.browser.metrics',
+    status: 'ok',
     parent_span_id: spanId,
     span_id: expect.stringMatching(/^[a-f\d]{16}$/),
     start_timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/test.ts

@@ -79,6 +79,7 @@ sentryTest('should capture an INP click event span after pageload', async ({ bro
     exclusive_time: inpValue,
     op: 'ui.interaction.click',
     origin: 'auto.http.browser.inp',
+    status: 'ok',
     is_segment: true,
     segment_id: spanEnvelopeItem.span_id,
     span_id: expect.stringMatching(/[a-f\d]{16}/),

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-navigate/test.ts

@@ -82,6 +82,7 @@ sentryTest(
       exclusive_time: inpValue,
       op: 'ui.interaction.click',
       origin: 'auto.http.browser.inp',
+      status: 'ok',
       is_segment: true,
       segment_id: spanEnvelopeItem.span_id,
       span_id: expect.stringMatching(/[a-f\d]{16}/),
@@ -163,6 +164,7 @@ sentryTest(
       exclusive_time: inpValue,
       op: 'ui.interaction.click',
       origin: 'auto.http.browser.inp',
+      status: 'ok',
       is_segment: true,
       segment_id: spanEnvelopeItem.span_id,
       span_id: expect.stringMatching(/[a-f\d]{16}/),

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/test.ts

@@ -82,6 +82,7 @@ sentryTest(
       exclusive_time: inpValue,
       op: 'ui.interaction.click',
       origin: 'auto.http.browser.inp',
+      status: 'ok',
       is_segment: true,
       segment_id: spanEnvelopeItem.span_id,
       span_id: expect.stringMatching(/[a-f\d]{16}/),

dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/test.ts

@@ -79,6 +79,7 @@ sentryTest(
       exclusive_time: inpValue,
       op: 'ui.interaction.click',
       origin: 'auto.http.browser.inp',
+      status: 'ok',
       segment_id: expect.not.stringMatching(spanEnvelopeItem.span_id!),
       // parent is the pageload span
       parent_span_id: expect.stringMatching(/[a-f\d]{16}/),