Mask SNS PhoneNumber in messaging.destination span attributes

Author: andreiborza

packages/server-utils/src/integrations/tracing-channel/aws-sdk/services/sns.ts

@@ -26,7 +26,7 @@ export class SnsServiceExtension implements ServiceExtension {
       const { TopicArn, TargetArn, PhoneNumber } = request.commandInput;
       const destinationName = extractDestinationName(TopicArn, TargetArn, PhoneNumber);
       spanAttributes[ATTR_MESSAGING_DESTINATION] = destinationName;
-      spanAttributes[MESSAGING_DESTINATION_NAME] = TopicArn || TargetArn || PhoneNumber || 'unknown';
+      spanAttributes[MESSAGING_DESTINATION_NAME] = TopicArn || TargetArn || (PhoneNumber ? 'phone_number' : 'unknown');
 
       spanName = `${PhoneNumber ? 'phone_number' : destinationName} send`;
     }
@@ -67,7 +67,7 @@ function extractDestinationName(topicArn: string, targetArn: string, phoneNumber
       return arn;
     }
   } else if (phoneNumber) {
-    return phoneNumber;
+    return 'phone_number';
   } else {
     return 'unknown';
   }