Skip to content

Commit fd986a2

Browse files
authored
test: Drop Node v18 tests (#22428)
1 parent 9f038f9 commit fd986a2

3 files changed

Lines changed: 6 additions & 41 deletions

File tree

.github/workflows/build.yml

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ jobs:
567567
strategy:
568568
fail-fast: false
569569
matrix:
570-
node: [18, 20, 22, 24, 26]
570+
node: [20.19, 22.12, 24, 26]
571571
steps:
572572
- name: Check out base commit (${{ github.event.pull_request.base.sha }})
573573
uses: actions/checkout@v7
@@ -793,7 +793,7 @@ jobs:
793793
strategy:
794794
fail-fast: false
795795
matrix:
796-
node: [18, 20, 22, 24, 26]
796+
node: [20.19, 22.12, 24, 26]
797797
typescript:
798798
- false
799799
use_orchestrion:
@@ -803,9 +803,9 @@ jobs:
803803
- node: 24
804804
typescript: '3.8'
805805
# No need to test orchestrion for v18
806-
- node: 20
806+
- node: 20.19
807807
use_orchestrion: 'true'
808-
- node: 22
808+
- node: 22.12
809809
use_orchestrion: 'true'
810810
- node: 24
811811
use_orchestrion: 'true'
@@ -849,28 +849,6 @@ jobs:
849849
env:
850850
INJECT_ORCHESTRION: ${{ matrix.use_orchestrion }}
851851

852-
job_node_v18_compat:
853-
name: Node v18.0.0 Compatibility Check
854-
needs: [job_get_metadata, job_build]
855-
if: needs.job_build.outputs.changed_node == 'true' || github.event_name != 'pull_request'
856-
runs-on: ubuntu-24.04
857-
timeout-minutes: 5
858-
steps:
859-
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
860-
uses: actions/checkout@v7
861-
with:
862-
ref: ${{ env.HEAD_COMMIT }}
863-
- name: Set up Node
864-
uses: actions/setup-node@v6
865-
with:
866-
node-version: '18.0.0'
867-
- name: Restore caches
868-
uses: ./.github/actions/restore-cache
869-
with:
870-
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
871-
- name: Check Node v18.0.0 compatibility
872-
run: node scripts/node-v18-compat-check.js
873-
874852
job_node_core_integration_tests:
875853
name:
876854
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Node-Core
@@ -882,7 +860,7 @@ jobs:
882860
strategy:
883861
fail-fast: false
884862
matrix:
885-
node: [18, 20, 22, 24, 26]
863+
node: [20.19, 22.12, 24, 26]
886864
typescript:
887865
- false
888866
include:
@@ -945,7 +923,7 @@ jobs:
945923
strategy:
946924
fail-fast: false
947925
matrix:
948-
node: [18, 20, 22, 24, 26]
926+
node: [20.19, 22.12, 24, 26]
949927
steps:
950928
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
951929
uses: actions/checkout@v7
@@ -1321,7 +1299,6 @@ jobs:
13211299
job_deno_unit_tests,
13221300
job_node_unit_tests,
13231301
job_node_integration_tests,
1324-
job_node_v18_compat,
13251302
job_node_core_integration_tests,
13261303
job_cloudflare_integration_tests,
13271304
job_bundler_plugin_integration_tests,

dev-packages/e2e-tests/test-applications/aws-serverless-layer/package.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@
3636
"build-command": "NODE_VERSION=22 pnpm test:build",
3737
"assert-command": "NODE_VERSION=22 pnpm test:assert",
3838
"label": "aws-serverless-layer (Node 22)"
39-
},
40-
{
41-
"build-command": "NODE_VERSION=18 pnpm test:build",
42-
"assert-command": "NODE_VERSION=18 pnpm test:assert",
43-
"label": "aws-serverless-layer (Node 18)"
4439
}
4540
]
4641
}

scripts/node-v18-compat-check.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)