fixes

Author: mydea

packages/browser/src/tracing/backgroundtab.ts

@@ -27,7 +27,7 @@ export function registerBackgroundTabDetection(): void {
 
         // We should not set status if it is already set, this prevent important statuses like
         // error or data loss from being overwritten on transaction.
-        if (!status) {
+        if (status === 'ok') {
           rootSpan.setStatus({ code: SPAN_STATUS_ERROR, message: cancelledStatus });
         }
 

packages/core/src/tracing/trace.ts

@@ -91,7 +91,7 @@ export function startSpan<T>(options: StartSpanOptions, callback: (span: Span) =
         () => {
           // Only update the span status if it hasn't been changed yet, and the span is not yet finished
           const { status } = spanToJSON(activeSpan);
-          if (activeSpan.isRecording() && (!status || status === 'ok')) {
+          if (activeSpan.isRecording() && status === 'ok') {
             activeSpan.setStatus({ code: SPAN_STATUS_ERROR, message: 'internal_error' });
           }
         },
@@ -157,7 +157,7 @@ export function startSpanManual<T>(options: StartSpanOptions, callback: (span: S
         () => {
           // Only update the span status if it hasn't been changed yet, and the span is not yet finished
           const { status } = spanToJSON(activeSpan);
-          if (activeSpan.isRecording() && (!status || status === 'ok')) {
+          if (activeSpan.isRecording() && status === 'ok') {
             activeSpan.setStatus({ code: SPAN_STATUS_ERROR, message: 'internal_error' });
           }
         },

packages/opentelemetry/src/applyOtelSpanData.ts

@@ -109,10 +109,10 @@ export function applyOtelSpanKind(span: Span, kind: SpanKind | undefined): void
 function applyOtelSpanStatus(
   span: Span,
   attributes: SpanAttributes,
-  status: string | undefined,
+  status: string,
   spanStreamingEnabled: boolean,
 ): void {
-  if (status === undefined) {
+  if (status === 'ok') {
     span.setStatus(inferStatusFromAttributes(attributes) || { code: SPAN_STATUS_OK });
     return;
   }

packages/opentelemetry/src/trace.ts

@@ -77,7 +77,7 @@ function _startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: Span)
             return handleCallbackErrors(
               () => callback(span),
               () => {
-                // Only set the span status to ERROR when there wasn't any status set before, in order to avoid stomping useful span statuses
+                // Only set the span status to ERROR when there wasn't any error status set before, in order to avoid stomping useful span statuses
                 if (spanToJSON(span).status === 'ok') {
                   span.setStatus({ code: SpanStatusCode.ERROR });
                 }
@@ -94,7 +94,7 @@ function _startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: Span)
       return handleCallbackErrors(
         () => callback(span),
         () => {
-          // Only set the span status to ERROR when there wasn't any status set before, in order to avoid stomping useful span statuses
+          // Only set the span status to ERROR when there wasn't any error status set before, in order to avoid stomping useful span statuses
           if (spanToJSON(span).status === 'ok') {
             span.setStatus({ code: SpanStatusCode.ERROR });
           }