Skip to content

Commit 6d12e05

Browse files
committed
ref: rename to isAppRestart
1 parent eb57302 commit 6d12e05

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/core/src/js/tracing/reactnavigation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ export const reactNavigationIntegration = ({
210210
* It does not name the transaction or populate it with route information. Instead, it waits for the state to fully change
211211
* and gets the route information from there, @see updateLatestNavigationSpanWithCurrentRoute
212212
*/
213-
const startIdleNavigationSpan = (unknownEvent?: unknown, isFromRunApplication = false): void => {
213+
const startIdleNavigationSpan = (unknownEvent?: unknown, isAppRestart = false): void => {
214214
const event = unknownEvent as UnsafeAction | undefined;
215215
if (useDispatchedActionData && event?.data.noop) {
216216
debug.log(`${INTEGRATION_NAME} Navigation action is a noop, not starting navigation span.`);
@@ -245,7 +245,7 @@ export const reactNavigationIntegration = ({
245245
tracing?.options.beforeStartSpan
246246
? tracing.options.beforeStartSpan(getDefaultIdleNavigationSpanOptions())
247247
: getDefaultIdleNavigationSpanOptions(),
248-
{ ...idleSpanOptions, isFromRunApplication },
248+
{ ...idleSpanOptions, isAppRestart },
249249
);
250250
latestNavigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SPAN_ORIGIN_AUTO_NAVIGATION_REACT_NAVIGATION);
251251
latestNavigationSpan?.setAttribute(SEMANTIC_ATTRIBUTE_NAVIGATION_ACTION_TYPE, navigationActionType);

packages/core/src/js/tracing/span.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ export const startIdleNavigationSpan = (
4949
{
5050
finalTimeout = defaultIdleOptions.finalTimeout,
5151
idleTimeout = defaultIdleOptions.idleTimeout,
52-
isFromRunApplication = false,
53-
}: Partial<typeof defaultIdleOptions> & { isFromRunApplication?: boolean } = {},
52+
isAppRestart = false,
53+
}: Partial<typeof defaultIdleOptions> & { isAppRestart?: boolean } = {},
5454
): Span | undefined => {
5555
const client = getClient();
5656
if (!client) {
@@ -63,7 +63,7 @@ export const startIdleNavigationSpan = (
6363

6464
// Don't cancel user interaction spans when starting from runApplication (app restart/reload).
6565
// This preserves the span context for error capture and replay recording.
66-
if (isActiveSpanInteraction && isFromRunApplication) {
66+
if (isActiveSpanInteraction && isAppRestart) {
6767
debug.log(
6868
`[startIdleNavigationSpan] Not canceling ${
6969
spanToJSON(activeSpan).op

packages/core/test/tracing/idleNavigationSpan.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ describe('startIdleNavigationSpan', () => {
211211
{
212212
name: 'test',
213213
},
214-
{ isFromRunApplication: true },
214+
{ isAppRestart: true },
215215
);
216216

217217
// User interaction span should NOT be cancelled/ended - preserving it for replay capture

0 commit comments

Comments
 (0)