Skip to content

Commit f8a058d

Browse files
authored
fix: Make stacktrace merging default off
This always causes problems so we are making the default off
1 parent 0561306 commit f8a058d

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

.npmignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ docs
44
.idea
55
appium
66
.vscode
7+
.travis
8+
.github
79

810
# KSCrash
911
ios/Sentry/KSCrash

appium/fastlane/Fastfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ def validate_android_build_output(output)
99
UI.user_error!("4 Missing output in log") unless output.scan(/"dist": "3", "name": "~\/index.android.bundle"/).size >= 1
1010
UI.user_error!("5 Missing output in log") unless output.scan(/"dist": "4", "name": "~\/index.android.bundle.map"/).size >= 1
1111
UI.user_error!("6 Missing output in log") unless output.scan(/"dist": "3", "name": "~\/index.android.bundle.map"/).size >= 1
12-
UI.user_error!("7 Missing output in log") unless output.scan(/sentry_cli::commands::react_native_gradle.*intermediates\/assets\/full\/release\/index.android.bundle$/).size >= 1
13-
UI.user_error!("8 Missing output in log") unless output.scan(/sentry_cli::commands::react_native_gradle.*intermediates\/assets\/full\/release\/index.android.bundle.map$/).size >= 1
14-
UI.user_error!("9 Missing output in log") unless output.scan(/sentry_cli::commands::react_native_gradle.*intermediates\/assets\/demo\/release\/index.android.bundle$/).size >= 1
15-
UI.user_error!("10 Missing output in log") unless output.scan(/sentry_cli::commands::react_native_gradle.*intermediates\/assets\/demo\/release\/index.android.bundle.map$/).size >= 1
1612
UI.success("Android build output validated")
1713
end
1814

docs/config.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ These are functions you can call in your javascript code:
1313

1414
// disable stacktrace merging
1515
Sentry.config("___DSN___", {
16-
deactivateStacktraceMerging: true, // default: false | Deactivates the stacktrace merging feature
16+
deactivateStacktraceMerging: false, // default: true | Deactivates the stacktrace merging feature
1717
logLevel: SentryLog.Debug, // default SentryLog.None | Possible values: .None, .Error, .Debug, .Verbose
1818
disableNativeIntegration: false // default: false | Deactivates the native integration and only uses raven-js
1919
// sampleRate: 0.5 // default: 1.0 | Only set this if you don't want to send every event so e.g.: 0.5 will send 50% of all events

docs/index.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ Mixed Stacktraces
9696
-----------------
9797

9898
Currently we only support mixed stacktraces on iOS. By default this feature is
99-
enabled. If you encounter performance issues we recommend try turning it
100-
off ``deactivateStacktraceMerging: true`` see: :doc:`config`.
99+
disabled. We recommend testing your app thoroughly when activating this, to turn
100+
it on ``deactivateStacktraceMerging: false`` see: :doc:`config`.
101101

102102
Deep Dive
103103
---------

lib/NativeClient.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export class NativeClient {
5151
this.options = {
5252
ignoreModulesExclude: [],
5353
ignoreModulesInclude: [],
54-
deactivateStacktraceMerging: false
54+
deactivateStacktraceMerging: true
5555
};
5656
Object.assign(this.options, options);
5757

0 commit comments

Comments
 (0)