Skip to content

Commit ca9b05b

Browse files
authored
chore: bump design-core and simplify button CSS (#11124)
Update dependency versions 1.3.1, remove redundant hover variables, and keep outline text color consistent on hover.
1 parent 9223622 commit ca9b05b

File tree

5 files changed

+46
-26
lines changed

5 files changed

+46
-26
lines changed

apps/desktop/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
},
2525
"devDependencies": {
2626
"@anthropic-ai/sdk": "^0.59.0",
27-
"@gitbutler/design-core": "^1.2.6",
27+
"@gitbutler/design-core": "^1.3.2",
2828
"@gitbutler/core": "workspace:*",
2929
"@gitbutler/shared": "workspace:*",
3030
"@gitbutler/svelte-comment-injector": "workspace:*",

apps/web/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
},
1616
"devDependencies": {
1717
"@csstools/postcss-global-data": "^3.0.0",
18-
"@gitbutler/design-core": "^1.2.6",
18+
"@gitbutler/design-core": "^1.3.2",
1919
"@gitbutler/core": "workspace:*",
2020
"@gitbutler/shared": "workspace:*",
2121
"@gitbutler/ui": "workspace:*",

packages/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@codemirror/language": "^6.11.2",
4848
"@codemirror/legacy-modes": "^6.5.2",
4949
"@csstools/postcss-bundler": "^2.0.8",
50-
"@gitbutler/design-core": "^1.2.6",
50+
"@gitbutler/design-core": "^1.3.2",
5151
"@lezer/common": "^1.2.3",
5252
"@lezer/highlight": "^1.2.1",
5353
"@playwright/experimental-ct-svelte": "^1.56.1",

packages/ui/src/lib/components/Button.svelte

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@
299299
/* Theme Variables - All themes use the same pattern */
300300
:where(&.neutral) {
301301
--theme-outline-text: var(--clr-btn-ntrl-outline-text);
302-
--theme-outline-text-hover: var(--clr-btn-ntrl-outline-text-hover);
303302
--theme-outline-bg: var(--clr-btn-ntrl-outline-bg);
304303
--theme-outline-border: var(--clr-btn-ntrl-outline);
305304
--theme-solid-text: var(--clr-theme-ntrl-on-element);
@@ -309,7 +308,6 @@
309308
310309
:where(&.pop) {
311310
--theme-outline-text: var(--clr-btn-pop-outline-text);
312-
--theme-outline-text-hover: var(--clr-btn-pop-outline-text-hover);
313311
--theme-outline-bg: var(--clr-btn-pop-outline-bg);
314312
--theme-outline-border: var(--clr-btn-pop-outline);
315313
--theme-solid-text: var(--clr-theme-pop-on-element);
@@ -319,7 +317,6 @@
319317
320318
:where(&.success) {
321319
--theme-outline-text: var(--clr-btn-succ-outline-text);
322-
--theme-outline-text-hover: var(--clr-btn-succ-outline-text-hover);
323320
--theme-outline-bg: var(--clr-btn-succ-outline-bg);
324321
--theme-outline-border: var(--clr-btn-succ-outline);
325322
--theme-solid-text: var(--clr-theme-succ-on-element);
@@ -329,7 +326,6 @@
329326
330327
:where(&.error) {
331328
--theme-outline-text: var(--clr-btn-err-outline-text);
332-
--theme-outline-text-hover: var(--clr-btn-err-outline-text-hover);
333329
--theme-outline-bg: var(--clr-btn-err-outline-bg);
334330
--theme-outline-border: var(--clr-btn-err-outline);
335331
--theme-solid-text: var(--clr-theme-err-on-element);
@@ -339,7 +335,6 @@
339335
340336
:where(&.warning) {
341337
--theme-outline-text: var(--clr-btn-warn-outline-text);
342-
--theme-outline-text-hover: var(--clr-btn-warn-outline-text-hover);
343338
--theme-outline-bg: var(--clr-btn-warn-outline-bg);
344339
--theme-outline-border: var(--clr-btn-warn-outline);
345340
--theme-solid-text: var(--clr-theme-warn-on-element);
@@ -349,7 +344,6 @@
349344
350345
:where(&.purple) {
351346
--theme-outline-text: var(--clr-btn-purp-outline-text);
352-
--theme-outline-text-hover: var(--clr-btn-purp-outline-text-hover);
353347
--theme-outline-bg: var(--clr-btn-purp-outline-bg);
354348
--theme-outline-border: var(--clr-btn-purp-outline);
355349
--theme-solid-text: var(--clr-theme-purp-on-element);
@@ -364,12 +358,7 @@
364358
--btn-bg: var(--theme-outline-bg);
365359
}
366360
367-
:where(&.outline:not(:disabled):hover),
368-
:where(&.ghost:not(:disabled):hover),
369-
:where(&.outline.activated),
370-
:where(&.ghost.activated) {
371-
--label-clr: var(--theme-outline-text-hover);
372-
}
361+
/* Hover and activated states maintain the same text color as default state */
373362
374363
:where(&.outline) {
375364
--btn-border-clr: var(--theme-outline-border);

pnpm-lock.yaml

Lines changed: 42 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)