feat: hotkeys

Signed-off-by: Adam Setch <adam.setch@outlook.com>

Author: setchy

src/renderer/App.tsx

@@ -41,8 +41,8 @@ export const App = () => {
     <ThemeProvider>
       <BaseStyles>
         <AppProvider>
-          <GlobalShortcuts />
           <Router>
+            <GlobalShortcuts />
             <AppLayout>
               <Routes>
                 <Route

src/renderer/components/GlobalShortcuts.test.tsx

@@ -4,6 +4,7 @@ import { MemoryRouter } from 'react-router-dom';
 import { renderWithAppContext } from '../__helpers__/test-utils';
 
 import * as comms from '../utils/comms';
+import * as links from '../utils/links';
 import { GlobalShortcuts } from './GlobalShortcuts';
 
 const navigateMock = jest.fn();
@@ -22,6 +23,20 @@ describe('components/GlobalShortcuts.tsx', () => {
   });
 
   describe('key bindings', () => {
+    describe('ignores keys that are not valid', () => {
+      it('ignores B key', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+        );
+
+        await userEvent.keyboard('b');
+
+        expect(navigateMock).not.toHaveBeenCalled();
+      });
+    });
+
     describe('home', () => {
       it('navigates home when pressing H key', async () => {
         renderWithAppContext(
@@ -36,6 +51,42 @@ describe('components/GlobalShortcuts.tsx', () => {
       });
     });
 
+    describe('openGitHubNotifications', () => {
+      const openGitHubNotificationsSpy = jest
+        .spyOn(links, 'openGitHubNotifications')
+        .mockImplementation();
+
+      it('opens primary account GitHub notifications webpage when pressing N while logged in', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: true,
+          },
+        );
+
+        await userEvent.keyboard('n');
+
+        expect(openGitHubNotificationsSpy).toHaveBeenCalledTimes(1);
+      });
+
+      it('does not open primary account GitHub notifications webpage when logged out', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: false,
+          },
+        );
+
+        await userEvent.keyboard('n');
+
+        expect(openGitHubNotificationsSpy).not.toHaveBeenCalled();
+      });
+    });
+
     describe('focus mode', () => {
       it('toggles focus when pressing W while logged in', async () => {
         renderWithAppContext(
@@ -119,6 +170,78 @@ describe('components/GlobalShortcuts.tsx', () => {
       });
     });
 
+    describe('openGitHubIssues', () => {
+      const openGitHubIssuesSpy = jest
+        .spyOn(links, 'openGitHubIssues')
+        .mockImplementation();
+
+      it('opens primary account GitHub issues webpage when pressing I while logged in', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: true,
+          },
+        );
+
+        await userEvent.keyboard('i');
+
+        expect(openGitHubIssuesSpy).toHaveBeenCalledTimes(1);
+      });
+
+      it('does not open primary account GitHub issues webpage when logged out', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: false,
+          },
+        );
+
+        await userEvent.keyboard('n');
+
+        expect(openGitHubIssuesSpy).not.toHaveBeenCalled();
+      });
+    });
+
+    describe('openGitHubPulls', () => {
+      const openGitHubPullsSpy = jest
+        .spyOn(links, 'openGitHubPulls')
+        .mockImplementation();
+
+      it('opens primary account GitHub pull requests webpage when pressing N while logged in', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: true,
+          },
+        );
+
+        await userEvent.keyboard('p');
+
+        expect(openGitHubPullsSpy).toHaveBeenCalledTimes(1);
+      });
+
+      it('does not open primary account GitHub pull requests webpage when logged out', async () => {
+        renderWithAppContext(
+          <MemoryRouter>
+            <GlobalShortcuts />
+          </MemoryRouter>,
+          {
+            isLoggedIn: false,
+          },
+        );
+
+        await userEvent.keyboard('n');
+
+        expect(openGitHubPullsSpy).not.toHaveBeenCalled();
+      });
+    });
+
     describe('refresh', () => {
       it('refreshes notifications when pressing R key', async () => {
         renderWithAppContext(

src/renderer/components/Sidebar.tsx

@@ -18,12 +18,6 @@ import { APPLICATION } from '../../shared/constants';
 import { useAppContext } from '../hooks/useAppContext';
 import { useShortcutActions } from '../hooks/useShortcutActions';
 
-import { getPrimaryAccountHostname } from '../utils/auth/utils';
-import {
-  openGitHubIssues,
-  openGitHubNotifications,
-  openGitHubPulls,
-} from '../utils/links';
 import { hasActiveFilters } from '../utils/notifications/filters/filter';
 import { LogoIcon } from './icons/LogoIcon';
 
@@ -32,13 +26,10 @@ export const Sidebar: FC = () => {
     status,
     isLoggedIn,
     settings,
-    auth,
     notificationCount,
     hasUnreadNotifications,
   } = useAppContext();
 
-  const primaryAccountHostname = getPrimaryAccountHostname(auth);
-
   const { shortcuts } = useShortcutActions();
 
   const isLoading = status === 'loading';
@@ -72,7 +63,8 @@ export const Sidebar: FC = () => {
           data-testid="sidebar-notifications"
           description={`${notificationCount} ${settings.fetchReadNotifications ? 'notifications' : 'unread notifications'} ↗`}
           icon={BellIcon}
-          onClick={() => openGitHubNotifications(primaryAccountHostname)}
+          keybindingHint={shortcuts.myNotifications.key}
+          onClick={() => shortcuts.myNotifications.action()}
           size="small"
           tooltipDirection="e"
           variant={hasUnreadNotifications ? 'primary' : 'invisible'}
@@ -114,7 +106,8 @@ export const Sidebar: FC = () => {
           aria-label="My issues ↗"
           data-testid="sidebar-my-issues"
           icon={IssueOpenedIcon}
-          onClick={() => openGitHubIssues(primaryAccountHostname)}
+          keybindingHint={shortcuts.myIssues.key}
+          onClick={() => shortcuts.myIssues.action()}
           size="small"
           tooltipDirection="e"
           variant="invisible"
@@ -124,7 +117,8 @@ export const Sidebar: FC = () => {
           aria-label="My pull requests ↗"
           data-testid="sidebar-my-pull-requests"
           icon={GitPullRequestIcon}
-          onClick={() => openGitHubPulls(primaryAccountHostname)}
+          keybindingHint={shortcuts.myPullRequests.key}
+          onClick={() => shortcuts.myPullRequests.action()}
           size="small"
           tooltipDirection="e"
           variant="invisible"