test: add coverage for fetchReadNotifications fallback behavior

Author: afonsojramos

src/renderer/components/notifications/NotificationRow.test.tsx

@@ -136,6 +136,32 @@ describe('renderer/components/notifications/NotificationRow.tsx', () => {
       expect(markNotificationsAsDoneMock).toHaveBeenCalledTimes(1);
     });
 
+    it('should mark as read (not done) when markAsDoneOnOpen is true but fetchReadNotifications is enabled', async () => {
+      const markNotificationsAsReadMock = jest.fn();
+      const markNotificationsAsDoneMock = jest.fn();
+
+      const props = {
+        notification: mockGitifyNotification,
+        account: mockGitHubCloudAccount,
+      };
+
+      renderWithAppContext(<NotificationRow {...props} />, {
+        settings: {
+          ...mockSettings,
+          markAsDoneOnOpen: true,
+          fetchReadNotifications: true,
+        },
+        markNotificationsAsRead: markNotificationsAsReadMock,
+        markNotificationsAsDone: markNotificationsAsDoneMock,
+      });
+
+      await userEvent.click(screen.getByTestId('notification-row'));
+
+      expect(links.openNotification).toHaveBeenCalledTimes(1);
+      expect(markNotificationsAsReadMock).toHaveBeenCalledTimes(1);
+      expect(markNotificationsAsDoneMock).not.toHaveBeenCalled();
+    });
+
     it('should mark notifications as read', async () => {
       const markNotificationsAsReadMock = jest.fn();
 
@@ -190,6 +216,24 @@ describe('renderer/components/notifications/NotificationRow.tsx', () => {
       expect(markNotificationsAsDoneMock).toHaveBeenCalledTimes(1);
     });
 
+    it('should hide mark as done button when fetchReadNotifications is enabled', async () => {
+      const props = {
+        notification: mockGitifyNotification,
+        account: mockGitHubCloudAccount,
+      };
+
+      renderWithAppContext(<NotificationRow {...props} />, {
+        settings: { ...mockSettings, fetchReadNotifications: true },
+      });
+
+      expect(
+        screen.queryByTestId('notification-mark-as-done'),
+      ).not.toBeInTheDocument();
+      expect(
+        screen.getByTestId('notification-mark-as-read'),
+      ).toBeInTheDocument();
+    });
+
     it('should unsubscribe from a notification thread', async () => {
       const unsubscribeNotificationMock = jest.fn();
 

src/renderer/hooks/useNotifications.test.ts

@@ -585,5 +585,39 @@ describe('renderer/hooks/useNotifications.ts', () => {
       expect(result.current.notifications.length).toBe(0);
       expect(rendererLogErrorSpy).toHaveBeenCalledTimes(1);
     });
+
+    it('should mark as read (not done) when markAsDoneOnUnsubscribe is true but fetchReadNotifications is enabled', async () => {
+      // The unsubscribe endpoint call.
+      nock('https://api.github.com/')
+        .put(`/notifications/threads/${id}/subscription`)
+        .reply(200);
+
+      // The mark read endpoint call (NOT mark done).
+      nock('https://api.github.com/')
+        .patch(`/notifications/threads/${id}`)
+        .reply(200);
+
+      const { result } = renderHook(() => useNotifications());
+
+      act(() => {
+        result.current.unsubscribeNotification(
+          {
+            ...mockState,
+            settings: {
+              ...mockState.settings,
+              markAsDoneOnUnsubscribe: true,
+              fetchReadNotifications: true,
+            },
+          },
+          mockGitifyNotification,
+        );
+      });
+
+      await waitFor(() => {
+        expect(result.current.status).toBe('success');
+      });
+
+      expect(result.current.notifications.length).toBe(0);
+    });
   });
 });