Debugger QOL improvements and small fixes#944
Merged
Conversation
* Introduced by godotengine#848 * Fixes godotengine#935
* Property rename to match expected behavior: ** members now do not have a prefix in object instances: Member/Foo -> Foo ** Inherited properties now do have a prefix: Parent1/Foo, ParentOfParent1/Boo ** Categories are properly treated and not displayed as property * __repr__ support ** If the class contains __repr__ member, value of it will be used as a display name for it's instances representations. That works for Dictionary keys too. Smaller changes and fixes: * Arrays to display actual values for more complex types in preview (Vectors/Rects/etc) * Strings are 'quoted' (similar to other DAPs) * Rect2i fix (parse as int, not float) * StrnigName better representation in values and dict keys: &'StringName' * tasks discoverabilty: Added tasks for test and package to tasks.json.
Test project: update test proj
Contributor
Author
|
@Calinou, does this change look good to you? What is the path forward with the PR. |
Collaborator
|
These changes look good to me, thanks @MichaelXt! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugger QOL improvements and fixes
__repr__support__repr__member, value of it will be used as a display name for it's instances representations. That works for Dictionary keys too.Smaller changes and fixes:
testandpackageto tasks.json.The new class member names
The list/dict representation experience
Godot experience:
New vscode experience: