Skip to content

Fix Issue #8653 - Python vtables not considering object size #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2025
Merged

Fix Issue #8653 - Python vtables not considering object size #8683

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afb6de4
have vtables consider size
jtdavis777 Nov 5, 2025
5e892df
simplification from comment
jtdavis777 Nov 11, 2025
f3a1378
Merge branch 'master' into fix/python_vtables
jtdavis777 Nov 11, 2025
bab9ad8
Merge branch 'master' into fix/python_vtables
aardappel Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/flatbuffers/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,10 @@ def WriteVtable(self):

vtKey.append(elem)

objectSize = UOffsetTFlags.py_type(objectOffset - self.objectEnd)
vtKey.append(objectSize)
vtKey = tuple(vtKey)
# calculate the size of the object
vt2Offset = self.vtables.get(vtKey)
if vt2Offset is None:
# Did not find a vtable, so write this one to the buffer.
Expand Down Expand Up @@ -275,7 +278,6 @@ def WriteVtable(self):
# The two metadata fields are written last.

# First, store the object bytesize:
objectSize = UOffsetTFlags.py_type(objectOffset - self.objectEnd)
self.PrependVOffsetT(VOffsetTFlags.py_type(objectSize))

# Second, store the vtable bytesize:
Expand Down
Loading