google-assistant-sdk: use temporary file for html output

- write html content to file instead of using base64 encoded data-uri
  since content can be too long
- add tests for html output

Change-Id: Ia67114fa29ec54c54de8c27ddd3b085a8ed4d49f

Author: proppy

google-assistant-sdk/googlesamples/assistant/grpc/browser_helpers.py

@@ -12,9 +12,22 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import base64
+import os.path
+import tempfile
+import webbrowser
 
+ASSISTANT_HTML_FILE = 'google-assistant-sdk-screen-out.html'
 
-def to_data_uri(html):
-    return ('data:text/html;charset=utf-8;base64,%s'
-            % base64.b64encode(html).decode('utf-8'))
+
+class SystemBrowser(object):
+    def __init__(self):
+        self.tempdir = tempfile.mkdtemp()
+        self.filename = os.path.join(self.tempdir, ASSISTANT_HTML_FILE)
+
+    def display(self, html):
+        with open(self.filename, 'wb') as f:
+            f.write(html)
+        webbrowser.open(self.filename, new=0)
+
+
+system_browser = SystemBrowser()

google-assistant-sdk/googlesamples/assistant/grpc/textinput.py

@@ -17,7 +17,6 @@
 import os
 import logging
 import json
-import webbrowser
 
 import click
 import google.auth.transport.grpc
@@ -146,7 +145,8 @@ def iter_assist_requests():
               default='en-US',
               help='Language code of the Assistant')
 @click.option('--display', is_flag=True, default=False,
-              help='Enable visual display of Assistant Response.')
+              help='Enable visual display of Assistant '
+                   'rich media responses (for certain queries).')
 @click.option('--verbose', '-v', is_flag=True, default=False,
               help='Verbose logging.')
 @click.option('--grpc-deadline', default=DEFAULT_GRPC_DEADLINE,
@@ -183,7 +183,8 @@ def main(api_endpoint, credentials,
             click.echo('<you> %s' % query)
             response_text, response_html = assistant.assist(text_query=query)
             if display and response_html:
-                webbrowser.open(browser_helpers.to_data_uri(response_html))
+                system_browser = browser_helpers.system_browser
+                system_browser.display(response_html)
             if response_text:
                 click.echo('<@assistant> %s' % response_text)
 

google-assistant-sdk/tests/test_endtoend.py

@@ -136,6 +136,32 @@ def test_endtoend_textinput(device_model, device_instance):
     assert 'pamplemousse' in out
 
 
+def test_endtoend_htmloutput(device_model, device_instance):
+    temp_dir = tempfile.mkdtemp()
+    env = os.environ.copy()
+    env['TMPDIR'] = temp_dir
+    p = subprocess.Popen(['python', '-m',
+                          'googlesamples.assistant.grpc.textinput',
+                          '--verbose',
+                          '--device-model-id', device_model,
+                          '--device-id', device_instance,
+                          '--display'],
+                         stdin=subprocess.PIPE,
+                         stdout=subprocess.PIPE,
+                         env=env)
+    out, err = p.communicate(b'how do you say grapefruit in French?')
+    print(out)
+    out = builtins.str(out).lower()
+    assert err is None
+    assert 'grapefruit' in out
+    files = [os.path.join(path, f)
+             for path, _, fs in os.walk(temp_dir) for f in fs]
+    assert len(files) == 1
+    assert os.path.basename(files[0]) == 'google-assistant-sdk-screen-out.html'
+    with open(files[0], 'r') as f:
+        assert 'pamplemousse' in f.read()
+
+
 def test_endtoend_audiofileinput(device_model, device_instance):
     temp_dir = tempfile.mkdtemp()
     audio_out_file = os.path.join(temp_dir, 'out.raw')