Skip to content

Suggestions: Update setVisualization util to target the new 12.4 ui as well as the existing ui #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fastfrwrd wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Suggestions: Update setVisualization util to target the new 12.4 ui as well as the existing ui #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2df8b5c
Suggestions: Update setVisualization util to target the new 12.4 ui a…
fastfrwrd Nov 27, 2025
8ea544d
Update packages/plugin-e2e/src/models/pages/PanelEditPage.ts
fastfrwrd Dec 1, 2025
9d96382
Update packages/plugin-e2e/src/models/pages/PanelEditPage.ts
fastfrwrd Dec 1, 2025
c87d4e4
use true version check for this
fastfrwrd Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/plugin-e2e/src/models/pages/PanelEditPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,15 @@ export class PanelEditPage extends GrafanaPage {
}
await this.getByGrafanaSelector(this.ctx.selectors.components.PanelEditor.toggleVizPicker).click();
await this.getByGrafanaSelector(this.ctx.selectors.components.PluginVisualization.item(visualization)).click();

const selector = semver.gte(this.ctx.grafanaVersion, '12.4.0')
? // This will fail the typecheck until a PR in the grafana/grafana repo is merged that adds this selector
this.ctx.selectors.components.PanelEditor.OptionsPane.header
: this.ctx.selectors.components.PanelEditor.toggleVizPicker;

await expect(
this.getByGrafanaSelector(this.ctx.selectors.components.PanelEditor.toggleVizPicker),
`Could not set visualization to ${visualization}. Ensure the panel is installed.`
this.getByGrafanaSelector(selector),
`Failed to set visualization to ${visualization}. Ensure the panel is installed.`
).toHaveText(visualization);
}

Expand Down
Loading
Loading