Commit efef0dd
committed
servlet: Ignore timeoutOnSleepingServer for Tomcat
tomcat10Test is frequently failing on Windows because Tomcat doesn't
support trailers-only. I removed the FIXMEs because we won't workaround
Tomcat in grpc-servlet because:
1. An interceptor that converts trailers-only into headers+trailers
would handle most cases, as it could run directly next to the
application. That is semantically very safe. But an interceptor
doesn't help deadline handling and other transport-caused closures,
as those trailers-only are produced by the transport
2. Having the transport convert trailers-only would work for deadline
handling, but is not semantically safe
3. The other languages didn't find Tomcat to be important enough to
support HEADERS+empty DATA(END_STREAM) as trailers-only on the
client-side
```
Unexpected status: Status{code=INTERNAL, description=Received unexpected EOS on empty DATA frame from server, cause=null}
value of: getCode()
expected: DEADLINE_EXCEEDED
but was : INTERNAL
at app//io.grpc.testing.integration.AbstractInteropTest.assertCodeEquals(AbstractInteropTest.java:2028)
at app//io.grpc.testing.integration.AbstractInteropTest.timeoutOnSleepingServer(AbstractInteropTest.java:1644)
```1 parent 53cd1a2 commit efef0dd
File tree
1 file changed
+5
-4
lines changed- servlet/src/tomcatTest/java/io/grpc/servlet
1 file changed
+5
-4
lines changedLines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
117 | 116 | | |
118 | 117 | | |
119 | 118 | | |
120 | 119 | | |
121 | 120 | | |
122 | | - | |
123 | 121 | | |
124 | 122 | | |
125 | 123 | | |
126 | 124 | | |
127 | 125 | | |
128 | | - | |
129 | 126 | | |
130 | 127 | | |
131 | 128 | | |
132 | 129 | | |
133 | 130 | | |
134 | | - | |
135 | 131 | | |
136 | 132 | | |
137 | 133 | | |
138 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
139 | 140 | | |
0 commit comments