Repository navigation
Conversation
A repo's CI can report how a PR changes outputs (robocrystallographer compares 48 descriptions before and after). The triage bot could not read those logs, so it escalated without the answer. Allow gh run view and say in the rules to report what such a job found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@claude review this PR: is the change correct, and is it needed? |
Contributor
|
Yes, correct and needed. It changes agent rules, so @ardunn must decide.
Warning "No change" exemption trusts the PR's own CI. A PR can edit the comparison script. Details
|
Contributor
|
@claude is there ability for malicious actor to export env using these logs on fork pr |
Contributor
|
No new leak. The real risk is prompt injection, and the PR comments and diff already carry that risk.
Warning Weak point: an allowed command can expand shell variables, e.g. Hardening options
Status unchanged: still escalated to @ardunn. No new commits since the last review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the triage bot can't read CI job logs. robocrystallographer runs normal mode with
merge = deps, so the guard would have merged its spglib and inflect bumps. The bot escalated both because the libraries "can change the descriptions" (hackingmaterials/robocrystallographer#635, hackingmaterials/robocrystallographer#633). The repo'scomparejob had already answered that: its log says0 of 48 descriptions changefor each.Fix:
mergatron.yml: the triage bot may rungh run view, which only reads. Reruns are a separate command and stay off the list.Risk:
This touches the same allowed-tools line as #29, so whichever merges second needs a one-line rebase.
Tested:
gh run view --log --job <id>returns that line for both PRs. The full suite passes. Not yet run in a live bot job.Closes #32.
PR assisted by Claude Code.