Update ember-power-select, PowerSelectMultiple -> @multiple #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hashibot-hds
added
packages/components
docs-website
Collaborator
|
this potentially breaking, I think to be safe we should target v5 for this change, maybe. |
Member
Author
What do you think is breaking? |
Collaborator
Since there are consumer that BYO version of power select which might be lower then 8.11 where this API has been introduced we might run into issues. Maybe it's worth spinnning up RC build to test out on consumer but given that v5 is around the corner it might be just safer to target major release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR updates ember-power-select to the latest version and migrates from
PowerSelectMultipleto using@multiple, which is the new API for multiple selects andPowerSelectMultipleis deprecated.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.