Skip to content

Conversation

@tabito-hara
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR fixes the documentation of aws_codebuild_project regarding the import identifier.

  • In the current implementation, only the arn can be used as the import identifier. However, the previous documentation stated that name could be used.

    • Historically, both name and arn were accepted as identifiers during import, since the “Read” function uses findProjectByNameOrARN.
    • In addition, the documentation states:

      id - Name (if imported via name) or ARN (if created via Terraform or imported via ARN) of the CodeBuild project.

  • However, when resource identity was introduced, the arn was designated as the identifier, and the name can no longer be used, as verified in Imports aws_codebuild_project require ARN instead of name #44940.

Relations

Closes #44940

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. labels Nov 5, 2025
@tabito-hara tabito-hara marked this pull request as ready for review November 5, 2025 15:02
@tabito-hara tabito-hara requested a review from a team as a code owner November 5, 2025 15:02
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @tabito-hara. One item to change.

* `arn` - ARN of the CodeBuild project.
* `badge_url` - URL of the build badge when `badge_enabled` is enabled.
* `id` - Name (if imported via `name`) or ARN (if created via Terraform or imported via ARN) of the CodeBuild project.
* `id` - ARN of the CodeBuild project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of this resource type, since id is a duplicate of arn and is simply an implementation detail, it should be removed from the documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review.
id has been removed as suggested in 6f13b2b

@tabito-hara tabito-hara requested a review from gdavison November 6, 2025 22:48
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Imports aws_codebuild_project require ARN instead of name

3 participants