Skip to content

Conversation

@jackroberts-gh
Copy link

@jackroberts-gh jackroberts-gh commented Nov 10, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

  • Add encryption_key_arn to aws_backup_logically_air_gapped_vault resource.

New functionality now supports using a CMK to encrypt a LAG Vault:

https://aws.amazon.com/about-aws/whats-new/2025/11/aws-backup-kms-customer-managed-keys/

Relations

Closes #45010

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccBackupLogicallyAirGappedVault PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws-backup-lag-vault-kms-key-support 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupLogicallyAirGappedVault'  -timeout 360m -vet=off
2025/11/11 14:29:51 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/11 14:29:51 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBackupLogicallyAirGappedVault_basic
=== PAUSE TestAccBackupLogicallyAirGappedVault_basic
=== RUN   TestAccBackupLogicallyAirGappedVault_disappears
=== PAUSE TestAccBackupLogicallyAirGappedVault_disappears
=== RUN   TestAccBackupLogicallyAirGappedVault_encryptionKeyArn
=== PAUSE TestAccBackupLogicallyAirGappedVault_encryptionKeyArn
=== RUN   TestAccBackupLogicallyAirGappedVault_tags
=== PAUSE TestAccBackupLogicallyAirGappedVault_tags
=== CONT  TestAccBackupLogicallyAirGappedVault_basic
=== CONT  TestAccBackupLogicallyAirGappedVault_encryptionKeyArn
=== CONT  TestAccBackupLogicallyAirGappedVault_disappears
=== CONT  TestAccBackupLogicallyAirGappedVault_tags
--- PASS: TestAccBackupLogicallyAirGappedVault_encryptionKeyArn (21.68s)
--- PASS: TestAccBackupLogicallyAirGappedVault_disappears (150.84s)
--- PASS: TestAccBackupLogicallyAirGappedVault_basic (154.13s)
--- PASS: TestAccBackupLogicallyAirGappedVault_tags (448.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     452.980s

...

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/backup Issues and PRs that pertain to the backup service. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Nov 10, 2025
@jackroberts-gh jackroberts-gh force-pushed the f-aws-backup-lag-vault-kms-key-support branch from 993e559 to ffe343c Compare November 10, 2025 18:01
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Nov 11, 2025
@jackroberts-gh jackroberts-gh marked this pull request as ready for review November 11, 2025 14:42
@jackroberts-gh jackroberts-gh requested a review from a team as a code owner November 11, 2025 14:42
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support customer-managed keys for logically air-gapped backup vaults

2 participants