Skip to content

Commit 95523a7

Browse files
committed
feat(helm/release-chart)!: simplify chart name
Signed-off-by: Emilien Escalle <[email protected]>
1 parent 6b0d5ca commit 95523a7

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/workflows/__test-action-helm-release-chart.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
},
2828
{ "path": ".image.tag", "value": "0.1.0" }
2929
]
30+
3031
- name: umbrella-application
3132
values: |
3233
[
@@ -52,7 +53,7 @@ jobs:
5253
with:
5354
oci-registry: ghcr.io
5455
oci-registry-password: ${{ github.token }}
55-
chart: ${{ matrix.chart.name }}-test
56+
name: ${{ matrix.chart.name }}-test
5657
path: tests/charts/${{ matrix.chart.name }}
5758
values: ${{ matrix.chart.values }}
5859
tag: 0.1.0
@@ -62,7 +63,7 @@ jobs:
6263
# yamllint disable rule:line-length
6364
- name: Check release chart output
6465
run: |
65-
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container:0.1.0" ]; then
66+
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test:0.1.0" ]; then
6667
echo "Unexpected chart image name"
6768
exit 1
6869
fi
@@ -72,7 +73,7 @@ jobs:
7273
- name: Check chart status
7374
run: |
7475
echo ${{ github.token }} | helm registry login -u ${{ github.repository_owner }} --password-stdin ghcr.io
75-
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container
76+
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test
7677
env:
7778
HELM_EXPERIMENTAL_OCI: "1"
7879
# yamllint enable rule:line-length

actions/helm/release-chart/action.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ inputs:
2828
OCI registry password.
2929
See https://github.com/appany/helm-oci-chart-releaser#usage.
3030
default: ${{ github.token }}
31-
chart:
32-
description: "Chart name to release"
31+
name:
32+
description: "Chart repository name to release"
3333
required: true
3434
path:
3535
description: "Path to the chart to release"
@@ -329,9 +329,10 @@ runs:
329329
- id: chart-releaser
330330
uses: appany/helm-oci-chart-releaser@d94988c92bed2e09c6113981f15f8bb495d10943 # v0.5.0
331331
with:
332-
name: ${{ github.event.repository.name }}
333-
repository: ${{ github.repository }}/charts/${{ inputs.chart }}
332+
name: ${{ inputs.name }}
333+
repository: ${{ github.repository }}/charts
334334
tag: ${{ inputs.tag }}
335+
app_version: ${{ inputs.tag }}
335336
path: ${{ inputs.path }}
336337
registry: ${{ inputs.oci-registry }}
337338
registry_username: ${{ inputs.oci-registry-username }}

0 commit comments

Comments
 (0)