fix(docker/get-image-metada): set latest tag when necessary

Signed-off-by: Emilien Escalle <[email protected]>

Author: neilime

.github/workflows/__test-action-docker-build-image.yml

@@ -147,16 +147,23 @@ jobs:
             } else {
               const refTag = `${{ github.ref_name }}`;
 
-              assert.equal(builtImage.tags.length, 1, `"tags" output is not valid`);
+              assert.equal(builtImage.tags.length, 2, `"tags" output is not valid`);
               assert.equal(builtImage.tags[0], refTag, `"tags" output is not valid`);
+              assert.equal(builtImage.tags[1], "latest", `"tags" output is not valid`);
 
-              assert.equal(builtImage.images.length, 1, `"images" output is not valid`);
+              assert.equal(builtImage.images.length, 2, `"images" output is not valid`);
               assert.equal(
                 builtImage.images[0],
                 `ghcr.io/hoverkraft-tech/ci-github-container/application-test:${refTag}`,
                 `"images" output is not valid`
               );
 
+              assert.equal(
+                builtImage.images[1],
+                `ghcr.io/hoverkraft-tech/ci-github-container/application-test:latest`,
+                `"images" output is not valid`
+              );
+
               assert.equal(
                 builtImage.annotations["org.opencontainers.image.version"],
                 refTag,

.github/workflows/__test-action-get-image-metadata.yml

@@ -87,7 +87,7 @@ jobs:
                 `"tags" output must contain 2 tags for push event`
               );
 
-              assert.equal(tag[0],"ghcr.io/hoverkraft-tech/ci-github-container/application-test:main", `"tags" output is not valid`);
+              assert.equal(tags[0],"ghcr.io/hoverkraft-tech/ci-github-container/application-test:main", `"tags" output is not valid`);
               assert.equal(tags[1],"ghcr.io/hoverkraft-tech/ci-github-container/application-test:latest", `"tags" output is not valid`);
             }
 

actions/docker/get-image-metadata/action.yml

@@ -66,16 +66,17 @@ runs:
       with:
         result-encoding: string
         script: |
-          // If push on default branch set tag to latest
-          const isPushOnDefaultBranch = context.eventName === 'push' && `${{ github.ref }}` === `${{ github.event.repository.default_branch }}`;
-          core.setOutput('flavor', isPushOnDefaultBranch ? 'latest=true' : 'latest=false');
-
           const tagInput = `${{ inputs.tag }}`
           if (tagInput.length) {
             core.setOutput('tags',`type=semver,pattern={{raw}},value=${tagInput}`);
+            core.setOutput('flavor', 'latest=false');
             return;
           }
 
+          // If push on default branch set tag to latest
+          const isPushOnDefaultBranch = context.eventName === 'push' && `${{ github.ref }}` === `refs/heads/${{ github.event.repository.default_branch }}`;
+          core.setOutput('flavor', isPushOnDefaultBranch ? 'latest=true' : 'latest=false');
+
           const isPullRequestOrIssueComment =
             context.eventName === 'pull_request'
             || context.eventName === 'pull_request_review'
@@ -122,9 +123,21 @@ runs:
           core.setOutput('annotations', annotations);
 
           const tags = `${{ steps.docker-metadata.outputs.tags }}`;
+
           const sortedTags = tags
             .split("\n")
-            .sort((a, b) => b.length - a.length)
+            .sort((a, b) => {
+              // Move "latest" at the end
+              if (a.includes("latest")) {
+                return 1
+              };
+              if (b.includes("latest")) {
+                return -1
+              };
+
+              // Sort by length
+              return b.length - a.length;
+            })
             .join("\n");
 
           core.setOutput('tags', sortedTags);