Skip to content

Commit eaa119c

Browse files
committed
feat(helm/release-chart)!: simplify chart name
Signed-off-by: Emilien Escalle <[email protected]>
1 parent 49caa6c commit eaa119c

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/workflows/__test-action-helm-release-chart.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
},
3131
{ "path": ".image.tag", "value": "0.1.0" }
3232
]
33+
3334
- name: umbrella-application
3435
values: |
3536
[
@@ -55,7 +56,7 @@ jobs:
5556
with:
5657
oci-registry: ghcr.io
5758
oci-registry-password: ${{ github.token }}
58-
chart: ${{ matrix.chart.name }}-test
59+
name: ${{ matrix.chart.name }}-test
5960
path: tests/charts/${{ matrix.chart.name }}
6061
values: ${{ matrix.chart.values }}
6162
tag: 0.1.0
@@ -65,7 +66,7 @@ jobs:
6566
# yamllint disable rule:line-length
6667
- name: Check release chart output
6768
run: |
68-
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container:0.1.0" ]; then
69+
if [ "${{ steps.release-chart.outputs.image }}" != "ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test:0.1.0" ]; then
6970
echo "Unexpected chart image name"
7071
exit 1
7172
fi
@@ -75,7 +76,7 @@ jobs:
7576
- name: Check chart status
7677
run: |
7778
echo ${{ github.token }} | helm registry login -u ${{ github.repository_owner }} --password-stdin ghcr.io
78-
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test/ci-github-container
79+
helm pull --version "0.1.0" oci://ghcr.io/hoverkraft-tech/ci-github-container/charts/${{ matrix.chart.name }}-test
7980
env:
8081
HELM_EXPERIMENTAL_OCI: "1"
8182
# yamllint enable rule:line-length

actions/helm/release-chart/action.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ inputs:
2828
OCI registry password.
2929
See <https://github.com/appany/helm-oci-chart-releaser#usage>.
3030
default: ${{ github.token }}
31-
chart:
32-
description: "Chart name to release"
31+
name:
32+
description: "Chart repository name to release"
3333
required: true
3434
path:
3535
description: "Path to the chart to release"
@@ -313,9 +313,10 @@ runs:
313313
- id: chart-releaser
314314
uses: appany/helm-oci-chart-releaser@dd0551c15abe174eb57824ecde62e976091094da # v0.4.2
315315
with:
316-
name: ${{ github.event.repository.name }}
317-
repository: ${{ github.repository }}/charts/${{ inputs.chart }}
316+
name: ${{ inputs.name }}
317+
repository: ${{ github.repository }}/charts
318318
tag: ${{ inputs.tag }}
319+
app_version: ${{ inputs.tag }}
319320
path: ${{ inputs.path }}
320321
registry: ${{ inputs.oci-registry }}
321322
registry_username: ${{ inputs.oci-registry-username }}

0 commit comments

Comments
 (0)