Skip to content

Cancel pending renaming action for a screen in dtor of ScreensPanel #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenBE wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cancel pending renaming action for a screen in dtor of ScreensPanel #1783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ScreensPanel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ static const char* const DynamicFunctions[] = {" ", "Rename", " ", "

static void ScreensPanel_delete(Object* object) {
Panel* super = (Panel*) object;
ScreensPanel* const this = (ScreensPanel*) super;

/* cancel any pending edit action */
if (this->renamingItem) {
ListItem* item = (ListItem*) Panel_getSelected(super);
assert(item);
assert(item == this->renamingItem);

item->value = this->saved;
this->renamingItem = NULL;
super->cursorOn = false;

Panel_setSelectionColor(super, PANEL_SELECTION_FOCUS);
}

/* do not delete screen settings still in use */
int n = Panel_size(super);
Expand Down
Loading