Skip to content

Commit 43d9238

Browse files
committed
Standardize usage of CCID instead of CCNAME across samples
Improve simple-testing-network to check if monitoring should be enabled or not. Fix docker tag issues and add note to readme Small fix to minikube readme and CA image Signed-off-by: munapower <[email protected]>
1 parent 5a3481d commit 43d9238

File tree

29 files changed

+72
-55
lines changed

29 files changed

+72
-55
lines changed

ecc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ docker-fpc-app: docker-boilerplate-ecc
7373
exit 1;\
7474
fi
7575
echo "\033[1;33mWARNING: overriding $(DOCKER_IMAGE) docker image\033[0m"
76-
$(DOCKER) build $(DOCKER_BUILD_OPTS) -t $(DOCKER_IMAGE):$(FPC_VERSION) -f Dockerfile.fpc-app \
76+
$(DOCKER) build $(DOCKER_BUILD_OPTS) -t $(DOCKER_IMAGE):$(FPC_VERSION) -t $(DOCKER_IMAGE):latest -f Dockerfile.fpc-app \
7777
--build-arg HW_EXTENSION=$(HW_EXTENSION)\
7878
$(DOCKER_ENCLAVE_SO_PATH)
7979

ecc_go/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ Here provide a collection of useful developer notes which may help you while dev
122122
### Kill hanging containers
123123

124124
```bash
125-
docker kill $(docker ps -a -q --filter ancestor=fpc/ercc --filter ancestor=fpc/fpc-auction-go)
126-
docker rm $(docker ps -a -q --filter ancestor=fpc/ercc --filter ancestor=fpc/fpc-auction-go)
125+
docker kill $(docker ps -a -q --filter ancestor=fpc/ercc --filter ancestor=fpc/auction-go)
126+
docker rm $(docker ps -a -q --filter ancestor=fpc/ercc --filter ancestor=fpc/auction-go)
127127
```
128128

129129
More to come ...

ecc_go/build.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ecc_dependencies:
3737
# which forces ecc to always be built
3838

3939
env:
40-
echo "export CC_NAME=$(CC_NAME)" > details.env
40+
echo "export CC_ID=$(CC_ID)" > details.env
4141
echo "export FPC_MRENCLAVE=$(shell cat mrenclave)" >> details.env
4242
echo "export FPC_CHAINCODE_IMAGE=$(DOCKER_IMAGE):latest" >> details.env
4343

integration/go_chaincode/auction/topology.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424

2525
const (
2626
ChaincodeName = "auction"
27-
ChaincodeImageName = "fpc/fpc-auction-go"
27+
ChaincodeImageName = "fpc/auction-go"
2828
ChaincodeImageTag = "latest"
2929
)
3030

integration/go_chaincode/kv_test/topology.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222

2323
const (
2424
ChaincodeName = "kv-test"
25-
ChaincodeImageName = "fpc/fpc-kv-test-go"
25+
ChaincodeImageName = "fpc/kv-test-go"
2626
ChaincodeImageTag = "latest"
2727
)
2828

samples/application/simple-cli-go/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,6 @@ DOCKER_BUILD_OPTS += --no-cache
1616
docker:
1717
$(DOCKER) build $(DOCKER_BUILD_OPTS) \
1818
-t fpc/fpcclient:$(FPC_VERSION) \
19+
-t fpc/fpcclient:latest \
1920
-f Dockerfile \
2021
.

samples/application/simple-cli-go/cmd/root.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func initConfig() {
6464
CorePeerTLSKeyFile: getStrEnv("CORE_PEER_TLS_KEY_FILE"),
6565
CorePeerTLSRootCertFile: getStrEnv("CORE_PEER_TLS_ROOTCERT_FILE"),
6666
OrdererCA: getStrEnv("ORDERER_CA"),
67-
ChaincodeId: getStrEnv("CC_NAME"),
67+
ChaincodeId: getStrEnv("CC_ID"),
6868
ChannelId: getStrEnv("CHANNEL_NAME"),
6969
GatewayConfigPath: getStrEnv("GATEWAY_CONFIG"),
7070
}

samples/chaincode/auction-go/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
TOP = ../../..
77
include $(TOP)/ecc_go/build.mk
88

9-
CC_NAME ?= fpc-auction-go
9+
CC_NAME ?= auction-go

samples/chaincode/cc-tools-demo/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ Create a `Makefile` (i.e., `touch $FPC_PATH/samples/chaincode/cc-tools-demo/Make
157157
TOP = ../../..
158158
include $(TOP)/ecc_go/build.mk
159159

160-
CC_NAME ?= fpc-cc-tools-demo
160+
CC_NAME ?= cc-tools-demo
161161

162162
EGO_CONFIG_FILE = $(FPC_PATH)/samples/chaincode/cc-tools-demo/ccToolsDemoEnclave.json
163163
ECC_MAIN_FILES=$(FPC_PATH)/samples/chaincode/cc-tools-demo
@@ -200,10 +200,10 @@ Edit the file of the error `$FPC_PATH/samples/chaincode/cc-tools-demo/vendor/git
200200

201201
```
202202

203-
After building again, you can check that the `fpc/fpc-cc-tools-demo` image exists in your local docker registry using:
203+
After building again, you can check that the `fpc/cc-tools-demo` image exists in your local docker registry using:
204204

205205
```bash
206-
docker images | grep fpc-cc-tools-demo
206+
docker images | grep cc-tools-demo
207207
```
208208

209209
## Time to test!
@@ -288,7 +288,7 @@ cd $FPC_PATH/samples/application/simple-cli-go
288288
make
289289
290290
# export fpcclient settings
291-
export CC_NAME=cc-tools-demo
291+
export CC_ID=cc-tools-demo
292292
export CHANNEL_NAME=mychannel
293293
export CORE_PEER_ADDRESS=localhost:7051
294294
export CORE_PEER_ID=peer0.org1.example.com

samples/chaincode/cc-tools-demo/setup.sh

100644100755
File mode changed.

0 commit comments

Comments
 (0)