From b4b7f60c6010a71943a786dfa334bc45b02a96b7 Mon Sep 17 00:00:00 2001 From: Joe George Date: Wed, 8 Jul 2026 10:37:20 -0400 Subject: [PATCH 1/9] Fix factual and spec errors in docs content --- .../client-tutorial.md | 4 +-- .../server-tutorial.md | 2 +- .../icerpc-slice-tutorial/client-tutorial.md | 4 +-- .../icerpc-slice-tutorial/server-tutorial.md | 9 ++++-- .../getting-started/installation/template.md | 2 +- .../ice-definitions/sequence-types.md | 2 +- .../rpc-core/object-adapter.md | 2 +- .../di-and-icerpc-for-csharp.md | 6 ++-- .../icerpc/slic-transport/protocol-frames.md | 2 +- content/slice/basics/examples.md | 1 - content/slice/basics/slice-files.md | 16 +++++++--- content/slice/encoding/icerpc.md | 2 +- content/slice/encoding/primitive-types.md | 5 ++-- content/slice/encoding/user-defined-types.md | 2 +- content/slice/index.md | 6 ++-- content/slice/language-guide/attributes.md | 2 +- content/slice/language-guide/comments.md | 7 ++--- .../slice/language-guide/dictionary-types.md | 4 +-- content/slice/language-guide/interface.md | 4 +-- content/slice/language-guide/module.md | 4 +-- content/slice/language-guide/operation.md | 4 +-- .../slice/language-guide/sequence-types.md | 2 +- .../slice/language-reference/doc-comments.md | 4 --- .../preprocessor-directives.md | 2 +- .../slice/language-reference/slice-grammar.md | 30 +++++++++---------- 25 files changed, 69 insertions(+), 59 deletions(-) diff --git a/content/getting-started/icerpc-protobuf-tutorial/client-tutorial.md b/content/getting-started/icerpc-protobuf-tutorial/client-tutorial.md index c6c2b6e6a..7f111adc4 100644 --- a/content/getting-started/icerpc-protobuf-tutorial/client-tutorial.md +++ b/content/getting-started/icerpc-protobuf-tutorial/client-tutorial.md @@ -21,7 +21,7 @@ This command creates a new IceRPC client application in directory `MyProtobufCli Let's examine each file: -### proto/greeter.proto - the contract +### proto/visitor_center/greeter.proto - the contract This file is (and must be) identical or almost identical to the `greeter.proto` we used for the server: @@ -127,7 +127,7 @@ service that implements `Greeter`. With this code, the address of the target service (or [service address][service-address]) is the default for `Greeter`, namely `icerpc:/visitor_center.Greeter`. It matches the route we created in the server. -We could also create the same proxy with an explicit service address: +We could also create the same client with an explicit service address: ```csharp var greeter = new GreeterClient(pipeline, new Uri("icerpc:/visitor_center.Greeter")); diff --git a/content/getting-started/icerpc-protobuf-tutorial/server-tutorial.md b/content/getting-started/icerpc-protobuf-tutorial/server-tutorial.md index 48727282e..12c49c75a 100644 --- a/content/getting-started/icerpc-protobuf-tutorial/server-tutorial.md +++ b/content/getting-started/icerpc-protobuf-tutorial/server-tutorial.md @@ -40,7 +40,7 @@ This command creates a new IceRPC server application in directory `MyProtobufSer Let's examine each file: -### proto/greeter.proto - the contract +### proto/visitor_center/greeter.proto - the contract This file holds the contract between our client and server applications, specified with the [Protobuf] language. diff --git a/content/getting-started/icerpc-slice-tutorial/client-tutorial.md b/content/getting-started/icerpc-slice-tutorial/client-tutorial.md index d738ac829..656286dc6 100644 --- a/content/getting-started/icerpc-slice-tutorial/client-tutorial.md +++ b/content/getting-started/icerpc-slice-tutorial/client-tutorial.md @@ -21,7 +21,7 @@ This command creates a new IceRPC client application in directory `MySliceClient Let's examine each file: -### slice/Greeter.slice - the contract +### slice/VisitorCenter/Greeter.slice - the contract This file is (and must be) identical or almost identical to the `Greeter.slice` we used for the server: @@ -149,7 +149,7 @@ separate IceRpc NuGet packages: - [IceRpc.Slice] - the IceRPC + Slice integration package - [IceRpc.Slice.Tools] - the package that compiles `Greeter.slice` into - `generated/Greeter.IceRpc.cs` + `generated/Greeter.cs` and `generated/Greeter.IceRpc.cs` - [IceRpc.Deadline] and [IceRpc.Logger] - the packages with the two interceptors we installed in our invocation pipeline diff --git a/content/getting-started/icerpc-slice-tutorial/server-tutorial.md b/content/getting-started/icerpc-slice-tutorial/server-tutorial.md index 7ae528ddd..7531791f4 100644 --- a/content/getting-started/icerpc-slice-tutorial/server-tutorial.md +++ b/content/getting-started/icerpc-slice-tutorial/server-tutorial.md @@ -40,7 +40,7 @@ This command creates a new IceRPC server application in directory `MySliceServer Let's examine each file: -### slice/Greeter.slice - the contract +### slice/VisitorCenter/Greeter.slice - the contract This file holds the contract between our client and server applications, specified with the [Slice] language. @@ -181,6 +181,11 @@ await CancelKeyPressed; await server.ShutdownAsync(); ``` +### Program.Authentication.cs - AuthenticationOptions helper + +This file contains the `CreateServerAuthenticationOptions` helper method. It creates an +`SslServerAuthenticationOptions` from an `X509Certificate2`. + ### Program.CancelKeyPressed.cs - small Ctrl+C helper This file contains a few lines of code that `Program.cs` uses to wait for @@ -193,7 +198,7 @@ NuGet packages: - [IceRpc.Slice] - the IceRPC + Slice integration package - [IceRpc.Slice.Tools] - the package that compiles `Greeter.slice` into - `generated/Greeter.IceRpc.cs` + `generated/Greeter.cs` and `generated/Greeter.IceRpc.cs` - [IceRpc.Deadline] and [IceRpc.Logger] - the packages with the two middleware we installed in the dispatch pipeline diff --git a/content/getting-started/installation/template.md b/content/getting-started/installation/template.md index 852a403e5..b6e37182c 100644 --- a/content/getting-started/installation/template.md +++ b/content/getting-started/installation/template.md @@ -31,7 +31,7 @@ dotnet new install IceRpc.Templates ## Using the templates You use the IceRPC templates with the standard `dotnet new