feat(audience): Json — IL2CPP-safe manual JSON serialiser (SDK-128)#687
Merged
Conversation
nattb8
force-pushed
the
feat/sdk-128-json-serialiser
branch
3 times, most recently
from
aeabfe5 to
ba77249
Compare
…K-128) - Audience.Runtime.csproj + Audience.Tests.csproj: dotnet test harness for pure-C# modules (no Unity license needed in CI) - AssemblyInfo.cs: InternalsVisibleTo for test assembly, fixes internal visibility for both Unity test runner and dotnet - test-audience-sdk.yml: workflow triggers on PRs/pushes touching src/Packages/Audience/** - Fix Identity.Reset() to swallow DirectoryNotFoundException (not just FileNotFoundException) when consent=None left no directory on disk
nattb8
force-pushed
the
feat/sdk-128-json-serialiser
branch
from
ba77249 to
726126e
Compare
ImmutableJeffrey
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Json.cs— IL2CPP-safe manual JSON serialiser with no reflection, handling all SDK-required types with correct string escapingAudience.Runtime.csproj+Audience.Tests.csproj) andAssemblyInfo.cs(InternalsVisibleTo) so internal types are accessible from the test assembly in both Unity and dotnettest-audience-sdk.ymlGitHub Actions workflow — triggers on PRs touchingsrc/Packages/Audience/**, no Unity license needed (pure C# modules)Why manual JSON, not a library:
JsonUtilitycan't handleDictionary<string, object>; Json.NET adds ~500KB and needs AOT config for IL2CPP;System.Text.Jsonisn't bundled in Unity 2021's Mono runtime. The serialiser is ~80 lines with full test coverage and zero IL2CPP risk.Linear: SDK-128
🤖 Generated with Claude Code