Skip to content

Commit 687eb38

Browse files
committed
The API might break, but finish we will, damnit
1 parent 406f6cc commit 687eb38

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-hn",
3-
"version": "1.1.4",
3+
"version": "1.1.5",
44
"description": "React-powered frontend for Hacker News using its Firebase API",
55
"author": "Jonathan Buchanan",
66
"license": "MIT",

src/Comment.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ var Comment = React.createClass({
4545
},
4646

4747
componentDidUpdate(prevProps, prevState) {
48+
// Huge, fast-growing threads like https://news.ycombinator.com/item?id=9784470
49+
// seem to break the API - some comments are coming back from Firebase as null.
4850
if (!this.state.comment) {
51+
this.props.threadStore.adjustExpectedComments(-1)
4952
return
5053
}
5154

0 commit comments

Comments
 (0)