[ddi, hal] Using emplace C++11 instead insert make_pair

GermanAizek · GermanAizek · commit 0141fd236424 · 2025-04-21T19:12:34.000+03:00
diff --git a/media_driver/linux/common/ddi/media_ddi_factory.h b/media_driver/linux/common/ddi/media_ddi_factory.h
@@ -63,8 +63,7 @@ class MediaDdiFactory
     template <class C>
     static bool RegisterCodec(const KeyType &key)
     {
-        std::pair<iterator, bool> result =
-            GetCreators().insert(std::make_pair(key, create<C>));
+        std::pair<iterator, bool> result = GetCreators().emplace(key, create<C>);
 
         return result.second;
     }
diff --git a/media_softlet/agnostic/common/vp/hal/bufferMgr/vp_resource_manager.cpp b/media_softlet/agnostic/common/vp/hal/bufferMgr/vp_resource_manager.cpp
@@ -1285,7 +1285,7 @@ MOS_STATUS VpResourceManager::AssignFcResources(VP_EXECUTE_CAPS &caps, std::vect
                 m_fcIntermediaSurfaceInput[i]->rcSrc      = inputSurfaces[i]->rcSrc;
                 m_fcIntermediaSurfaceInput[i]->rcDst      = inputSurfaces[i]->rcDst;
                 m_fcIntermediaSurfaceInput[i]->SampleType = inputSurfaces[i]->SampleType;
-                surfSetting.surfGroup.insert(std::make_pair((SurfaceType)(SurfaceTypeFcIntermediaInput + i), m_fcIntermediaSurfaceInput[i]));
+                surfSetting.surfGroup.emplace((SurfaceType)(SurfaceTypeFcIntermediaInput + i), m_fcIntermediaSurfaceInput[i]);
             }
             if (fcSeparateIntermediaSecPlaneInputFormat != Format_Any)
             {

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ class MediaDdiFactory`
`63`	`63`	`template <class C>`
`64`	`64`	`static bool RegisterCodec(const KeyType &key)`
`65`	`65`	`{`
`66`		`- std::pair<iterator, bool> result =`
`67`		`- GetCreators().insert(std::make_pair(key, create<C>));`
	`66`	`+ std::pair<iterator, bool> result = GetCreators().emplace(key, create<C>);`
`68`	`67`
`69`	`68`	`return result.second;`
`70`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1285,7 +1285,7 @@ MOS_STATUS VpResourceManager::AssignFcResources(VP_EXECUTE_CAPS &caps, std::vect`
`1285`	`1285`	`m_fcIntermediaSurfaceInput[i]->rcSrc = inputSurfaces[i]->rcSrc;`
`1286`	`1286`	`m_fcIntermediaSurfaceInput[i]->rcDst = inputSurfaces[i]->rcDst;`
`1287`	`1287`	`m_fcIntermediaSurfaceInput[i]->SampleType = inputSurfaces[i]->SampleType;`
`1288`		`- surfSetting.surfGroup.insert(std::make_pair((SurfaceType)(SurfaceTypeFcIntermediaInput + i), m_fcIntermediaSurfaceInput[i]));`
	`1288`	`+ surfSetting.surfGroup.emplace((SurfaceType)(SurfaceTypeFcIntermediaInput + i), m_fcIntermediaSurfaceInput[i]);`
`1289`	`1289`	`}`
`1290`	`1290`	`if (fcSeparateIntermediaSecPlaneInputFormat != Format_Any)`
`1291`	`1291`	`{`