chore: improve message logic

russellwheatley · russellwheatley · commit afc13efc67eb · 2024-11-22T13:53:23.000Z
diff --git a/packages/app/lib/common/index.js b/packages/app/lib/common/index.js
@@ -152,11 +152,11 @@ export function createMessage(moduleName, methodName, uniqueMessage = '') {
   if (moduleMap) {
     const replacementMethodName = moduleMap[methodName];
     if (replacementMethodName) {
-      let message;
       if (replacementMethodName !== NO_REPLACEMENT) {
-        message = v8deprecationMessage + ` Please use \`${replacementMethodName}\` instead.`;
+        return v8deprecationMessage + ` Please use \`${replacementMethodName}\` instead.`;
+      } else {
+        return v8deprecationMessage;
       }
-      return message;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -152,11 +152,11 @@ export function createMessage(moduleName, methodName, uniqueMessage = '') {`
`152`	`152`	`if (moduleMap) {`
`153`	`153`	`const replacementMethodName = moduleMap[methodName];`
`154`	`154`	`if (replacementMethodName) {`
`155`		`- let message;`
`156`	`155`	`if (replacementMethodName !== NO_REPLACEMENT) {`
`157`		- message = v8deprecationMessage + ` Please use \`${replacementMethodName}\` instead.`;
	`156`	+ return v8deprecationMessage + ` Please use \`${replacementMethodName}\` instead.`;
	`157`	`+ } else {`
	`158`	`+ return v8deprecationMessage;`
`158`	`159`	`}`
`159`		`- return message;`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`	`}`