feat(local-notifications): add presentationOptions config support for iOS#2532
Closed
OS-ruimoreiramendes wants to merge 1 commit into
Closed
feat(local-notifications): add presentationOptions config support for iOS#2532OS-ruimoreiramendes wants to merge 1 commit into
OS-ruimoreiramendes wants to merge 1 commit into
Conversation
OS-ruimoreiramendes
requested review from
a team,
ItsChaceD,
OS-pedrogustavobilro,
alexgerardojacinto,
andredestro,
markemer and
theproducer
Contributor
|
@OS-ruimoreiramendes for this one shouldn't you merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
presentationOptionsconfig support to local-notifications on iOS, replacing the hardcoded[.badge, .sound, .alert]inwillPresent. The deprecated.alertis not exposed, only.badge,.sound,.bannerand.listare available.Default behaviour (when no config is provided) is
[.badge, .sound, .banner, .list], equivalent to the previous behaviour.Reference: https://outsystemsrd.atlassian.net/browse/RMET-5103
Change Type
Rationale / Problems Fixed
.alertinUNNotificationPresentationOptionsis deprecated since iOS 14. SincepresentationOptionsis being introduced from scratch inlocal-notifications, only the non deprecated values are exposed (badge,sound,bannerandlist), skippingalertentirely.Tests or Reproductions
Tested on a physical iOS device with the following
presentationOptionscombinations:["banner", "list", "sound"]: banner appears + sound plays + notification in notification center["banner", "sound"]: banner appears + sound plays["list", "sound"]: no banner + sound plays + notification in notification centerPlatforms Affected