Fix: cEOS stub interfaces must have P2P OSPF network type

Also: change the device type in vrf-igp transformation test to
'none' to make it aligned with most other transformation tests

Author: ipspace

docs/caveats.md

@@ -18,6 +18,7 @@
 * Arista EOS does not support routed port-channel interfaces. Port channel interfaces can be used only as VLAN trunks or VLAN access interfaces.
 * Anycast gateways and DHCP/DHCPv6 clients do not work on Arista cEOS Ethernet interfaces.
 * cEOS MPLS data plane was introduced in release 4.32.1F.
+* Arista cEOS disables OSPFv2 on broadcast container stub interfaces (implemented as _dummy_ interfaces). _netlab_ automatically changes the OSPF network type for Arista cEOS dummy interfaces to **point-to-point**.
 
 The default name of the management interface is **Management0** on vEOS and **Management1** on cEOS. If you'd like to change the management interface name on cEOS:
 

netsim/devices/eos.py

@@ -3,8 +3,9 @@
 #
 from box import Box
 
-from . import _Quirks
+from . import _Quirks,report_quirk
 from ..utils import log
+from ..modules import _routing
 from .. import data
 from ..augment import devices
 
@@ -102,6 +103,23 @@ def configure_ceos_attributes(node: Box, topology: Box) -> None:
   data.append_to_list(node.clab,'binds',f'clab_files/{node.name}/ceos-config:{mnt_config}')
   data.append_to_list(node.clab,'config_templates',f'ceos-config:{mnt_config}')
 
+def passive_stub_interfaces(node: Box, topology: Box) -> None:
+  if devices.get_provider(node,topology) != 'clab':
+    return
+
+  for intf in _routing.routing_protocol_interfaces(node,'ospf'):
+    if intf.type != 'stub' or 'ipv4' not in intf:
+      continue
+
+    report_quirk(
+      f'Changed OSPF network type on {node.name}/{intf.ifname} to point-to-point',
+      more_hints = [ f'Arista cEOS does not run OSPFv2 on container stub interfaces configured as broadcast networks' ],
+      node=node,
+      category=Warning,
+      quirk='ospf_stub')
+
+    intf.ospf.network_type = 'point-to-point'
+
 class EOS(_Quirks):
 
   @classmethod
@@ -119,5 +137,7 @@ def device_quirks(self, node: Box, topology: Box) -> None:
       check_dhcp_clients(node,topology)
     if 'lag' in mods:
       check_l3_lag(node,topology)
+    if 'ospf' in mods:
+      passive_stub_interfaces(node,topology)
     if 'eos' in node:
-      configure_ceos_attributes(node,topology)
+      configure_ceos_attributes(node,topology)