Terminal execute command from escaped brackets

[jcubic]

Issue summary

If you write XML inside escaped brackets, the terminal will invoke the HTML as extended command

Expected behavior

It should print the brackets and apply formatting inside

Steps to reproduce

1. Open repro

Browser and OS

N/A

Additional notes

The library probably unescapes the brackets on some point

[jcubic]

Another issue is calling:

term.echo($.terminal.escape_brackets($.terminal.apply_formatters(output)));
// Recursive loop in echo detected, skip

[iamazeem]

Hi @jcubic!
Thank you for creating this wonderful library! 🏆

I ran into a similar issue with JSON output:

const term = $('body').terminal({});
const output = `[[[]]]`;
term.echo(output);

resulting into this error:

Command '[' Not Found!

Setting the raw option fixed it:

const term = $('body').terminal({});
const output = `[[[]]]`;
term.echo(output, { raw: true });

Output:

[[[]]]

The indentation is lost though with raw option.

Shouldn't it be the default that the echo output is not treated as the new command? 🤔
Not sure if there are projects relying on this behavior.
However, providing an option to disable this would be great.

[jcubic]

This is not the same issue. Syntax like [[ command ]] is extended command syntax. You can use echo to execute a different command. With this feature, you can for instance use Server side to control the terminal.
You can use:

const term = $('body').terminal({});
const output = String.raw`\[\[\[\]\]\]`
term.echo(output);

The problem the issue describe is with escaping. It seems that the $.terminal.escape_brackets convert brackets into HTML entities and this type escaping doesn't actually escape extended commands.

[jcubic]

It seems that escape_brackets doesn't work at all:

const output = $.terminal.escape_brackets(`[[;white;]x]`);
term.echo(output);
// white x

It may be a regression that was not tested.

[iamazeem]

Thanks for the quick response! 👍
Specifically for JSON, $.terminal.escape_brackets seems to be working fine.

Syntax like [[ command ]] is extended command syntax. You can use echo to execute a different command. With this feature, you can for instance use Server side to control the terminal.

With output buffering, it may make sense to provide a flag to disable the extended command treatment.

For example:

// just buffer and do not treat it as an extended command
$('body').terminal().echo(`[[ ... ]]`, { flush: false });

const output = $('body').terminal().get_output_buffer();
$('body').terminal().clear_buffer();
$('body').terminal().echo($.terminal.escape_brackets(output));

UPDATE:

Adding exec: false for echo disables this behavior i.e.

$('body').terminal().echo(`[[ ... ]]`, { flush: false, exec: false });

---

For color codes too, it seems to be working fine on my side:

const output = $.terminal.escape_brackets(`[[;white;]x]`);
term.echo(output);
// [[;white;]x]

[jcubic]

Yes, it seems that the issue is only when xml formatter is included on the page. As in the description of the issue.