refactor: improve environment variable handling and test cleanup

- Move envConfigs to global scope for better reusability
- Add clearCoDevelopedByEnvVars utility function for centralized environment variable cleanup
- Update tests to use the new utility function instead of manual delete operations
- Improve code organization and maintainability
- All tests continue to pass successfully

This refactoring makes the code more maintainable and provides a centralized
way to manage environment variables used by the getCoDevelopedBy function.

Change-Id: Iac187f3977cdbffb28af9b316717288b50001045
Co-developed-by: Cursor <noreply@cursor.com>

Author: jiangxin

src/commands/exec.ts

@@ -5,6 +5,35 @@
 import * as fs from 'fs';
 import { spawnSync } from 'child_process';
 
+// Define environment variable configurations and their corresponding CoDevelopedBy values
+// Format: ["key=value", "co-developed-by-string"]
+const envConfigs: [string, string][] = [
+  // We can run CLI in IDE (such as Cursor and Qoder), so check CLI env variables first
+  ['CLAUDECODE=1', 'Claude <noreply@anthropic.com>'],
+  ['GEMINI_CLI=1', 'Gemini <noreply@developers.google.com>'],
+  // Check env variables for IDEs
+  ['VSCODE_BRAND=Qoder', 'Qoder <noreply@qoder.com>'],
+  ['CURSOR_TRACE_ID=*', 'Cursor <noreply@cursor.com>'],
+];
+
+/**
+ * Clear all environment variables used by getCoDevelopedBy function
+ * This is useful for testing to ensure clean state
+ */
+function clearCoDevelopedByEnvVars(): void {
+  for (const [envConfig] of envConfigs) {
+    const equalIndex = envConfig.indexOf('=');
+    if (equalIndex === -1) {
+      // No '=' found, just a key
+      delete process.env[envConfig];
+    } else {
+      // Split into key and value
+      const key = envConfig.substring(0, equalIndex);
+      delete process.env[key];
+    }
+  }
+}
+
 async function exec(messageFile: string): Promise<void> {
   console.log(`Executing commit-msg hook on file: ${messageFile}`);
 
@@ -147,17 +176,6 @@ function isMergeCommit(): boolean {
  * @returns The CoDevelopedBy value or empty string if not configured
  */
 function getCoDevelopedBy(): string {
-  // Define environment variable configurations and their corresponding CoDevelopedBy values
-  // Format: ["key=value", "co-developed-by-string"]
-  const envConfigs: [string, string][] = [
-    // We can run CLI in IDE (such as Cursor and Qoder), so check CLI env variables first
-    ['CLAUDECODE=1', 'Claude <noreply@anthropic.com>'],
-    ['GEMINI_CLI=1', 'Gemini <noreply@developers.google.com>'],
-    // Check env variables for IDEs
-    ['VSCODE_BRAND=Qoder', 'Qoder <noreply@qoder.com>'],
-    ['CURSOR_TRACE_ID=*', 'Cursor <noreply@cursor.com>'],
-  ];
-
   // Check each environment configuration in order
   for (const [envConfig, coDevelopedBy] of envConfigs) {
     // Parse the environment configuration
@@ -715,4 +733,5 @@ export {
   isMergeCommit,
   hasCoDevelopedBy,
   needsCoDevelopedBy,
+  clearCoDevelopedByEnvVars,
 };

test/commands/exec.test.ts

@@ -10,6 +10,7 @@ import {
   getCoDevelopedBy,
   hasCoDevelopedBy,
   needsCoDevelopedBy,
+  clearCoDevelopedByEnvVars,
 } from '../../src/commands/exec';
 
 describe('exec command utilities', () => {
@@ -513,11 +514,8 @@ describe('exec command utilities', () => {
     });
 
     it('should return empty string when environment variables are set to incorrect values', () => {
-      // Explicitly unset all environment variables we're testing
-      delete process.env.CLAUDECODE;
-      delete process.env.GEMINI_CLI;
-      delete process.env.VSCODE_BRAND;
-      delete process.env.CURSOR_TRACE_ID;
+      // Clear all environment variables using the utility function
+      clearCoDevelopedByEnvVars();
 
       process.env.CLAUDECODE = '0';
       process.env.GEMINI_CLI = '0';
@@ -526,11 +524,8 @@ describe('exec command utilities', () => {
     });
 
     it('should return empty string when environment variables exist but have no value', () => {
-      // Explicitly unset all environment variables we're testing
-      delete process.env.CLAUDECODE;
-      delete process.env.GEMINI_CLI;
-      delete process.env.VSCODE_BRAND;
-      delete process.env.CURSOR_TRACE_ID;
+      // Clear all environment variables using the utility function
+      clearCoDevelopedByEnvVars();
 
       process.env.CLAUDECODE = '';
       expect(getCoDevelopedBy()).toBe('');