♻️ Refactor DummyModel

Author: blegat

test/Test/modellike.jl

@@ -1,5 +1,5 @@
 @testset "ModelLike" begin
-    model = DummyModel{true}()
+    model = DummyModelWithAdd()
     MOIT.failcopytestc(model)
     MOIT.failcopytestia(model)
     MOIT.failcopytestva(model)

test/attributes.jl

@@ -10,7 +10,7 @@
         @test MOI.is_copyable(MOI.ObjectiveSense())
     end
     @testset "supports" begin
-        model = DummyModel{false}()
+        model = DummyModel()
         @test_throws ArgumentError MOI.supports(model, MOI.TerminationStatus())
         @test_throws ArgumentError begin
             MOI.supports(model, MOI.ConstraintSet(),

test/dummy.jl

@@ -1,19 +1,25 @@
-# DummyModel{true} implements add_variable and add_constraint
-struct DummyModel{A} <: MOI.ModelLike
-end
-MOI.add_variable(::DummyModel{true}) = MOI.VariableIndex(0)
-function MOI.empty!(::DummyModel) end
-function MOI.copy_to(dest::DummyModel, src::MOI.ModelLike; copy_names=true)
+abstract type AbstractDummyModel <: MOI.ModelLike end
+
+function MOI.empty!(::AbstractDummyModel) end
+function MOI.copy_to(dest::AbstractDummyModel, src::MOI.ModelLike; copy_names=true)
     return MOIU.default_copy_to(dest, src, copy_names)
 end
-MOI.supports(::DummyModel, ::MOI.ObjectiveSense) = true
-MOI.supports(::DummyModel, ::MOI.ConstraintPrimalStart,
+MOI.supports(::AbstractDummyModel, ::MOI.ObjectiveSense) = true
+MOI.supports(::AbstractDummyModel, ::MOI.ConstraintPrimalStart,
              ::Type{<:MOI.ConstraintIndex}) = true
-MOI.supports_constraint(::DummyModel, ::Type{MOI.SingleVariable},
+MOI.supports_constraint(::AbstractDummyModel, ::Type{MOI.SingleVariable},
                        ::Type{MOI.EqualTo{Float64}}) = true
-function MOI.add_constraint(::DummyModel{true}, ::MOI.SingleVariable,
+MOI.supports_constraint(::AbstractDummyModel, ::Type{MOI.VectorOfVariables},
+                       ::Type{MOI.Zeros}) = true
+
+struct DummyModel <: AbstractDummyModel
+end
+
+# Implements add_variable and add_constraint
+struct DummyModelWithAdd <: AbstractDummyModel
+end
+MOI.add_variable(::DummyModelWithAdd) = MOI.VariableIndex(0)
+function MOI.add_constraint(::DummyModelWithAdd, ::MOI.SingleVariable,
                             ::MOI.EqualTo{Float64})
     return MOI.ConstraintIndex{MOI.SingleVariable, MOI.EqualTo{Float64}}(0)
 end
-MOI.supports_constraint(::DummyModel, ::Type{MOI.VectorOfVariables},
-                       ::Type{MOI.Zeros}) = true

test/errors.jl

@@ -1,5 +1,5 @@
 @testset "Fallbacks for `set` methods" begin
-    model = DummyModel{false}()
+    model = DummyModel()
 
     @testset "AddVariableNotAllowed" begin
         @test_throws MOI.AddVariableNotAllowed MOI.add_variable(model)