From 900f3a0740bf2c79656f97908739e6fa5929801f Mon Sep 17 00:00:00 2001
From: juntaochi <53086415+juntaochi@users.noreply.github.com>
Date: Wed, 27 May 2026 15:57:24 +0000
Subject: [PATCH] perf(ui): inline duration formatting in App::update

Removed `format_duration` and `format_duration_seconds` helper functions that caused unnecessary string heap allocations. Inlined the logic into a single `format!` call in `App::update` to reduce allocations per update tick from 6 to 2.
---
 src/ui/mod.rs | 33 +++++++++++----------------------
 1 file changed, 11 insertions(+), 22 deletions(-)

diff --git a/src/ui/mod.rs b/src/ui/mod.rs
index 6bbba9d..c51fd15 100644
--- a/src/ui/mod.rs
+++ b/src/ui/mod.rs
@@ -9,7 +9,6 @@ use ratatui::{
 };
 use std::borrow::Cow;
 use std::sync::Arc;
-use std::time::Duration;
 use tokio::task::JoinHandle;
 
 use crate::artwork::converter::ArtworkConverter;
@@ -449,17 +448,18 @@ impl App {
             } else {
                 0
             };
+            let pos_secs = track.position.as_secs();
+            let dur_secs = track.duration.as_secs();
+            // Optimized: Inlined duration formatting to avoid 4 intermediate String heap
+            // allocations per update tick (previously done by helper functions).
             cache.duration_str = format!(
-                "{} / {}",
-                format_duration(track.position),
-                format_duration(track.duration)
-            );
-            cache.gauge_label = format!(
-                " {}/{} | {:02}% ",
-                format_duration_seconds(track.position),
-                format_duration_seconds(track.duration),
-                progress_percent
+                "{:02}:{:02} / {:02}:{:02}",
+                pos_secs / 60,
+                pos_secs % 60,
+                dur_secs / 60,
+                dur_secs % 60
             );
+            cache.gauge_label = format!(" {}s/{}s | {:02}% ", pos_secs, dur_secs, progress_percent);
             cache.progress_percent = progress_percent;
             self.metadata_cache = Some(cache);
         } else {
@@ -1029,18 +1029,6 @@ pub fn draw(f: &mut Frame, app: &mut App) {
     }
 }
 
-fn format_duration_seconds(duration: Duration) -> String {
-    let total_seconds = duration.as_secs();
-    format!("{}s", total_seconds)
-}
-
-fn format_duration(duration: Duration) -> String {
-    let total_seconds = duration.as_secs();
-    let minutes = total_seconds / 60;
-    let seconds = total_seconds % 60;
-    format!("{:02}:{:02}", minutes, seconds)
-}
-
 // Optimized: Uses iterator chaining/cycling to avoid intermediate Vec<char> and format! allocations.
 // Benchmark: ~32% speedup (329ms vs 484ms for 100k iters).
 fn scroll_text<'a>(text: &'a str, width: usize, frame: u32) -> Cow<'a, str> {
@@ -1070,6 +1058,7 @@ mod tests {
     use async_trait::async_trait;
     use ratatui::backend::TestBackend;
     use ratatui::Terminal;
+    use std::time::Duration;
 
     struct MockPlayer {
         volume: u8,