From 6afe111179f5222cce9bdec361ae9cd495dd2e1e Mon Sep 17 00:00:00 2001 From: juntaochi <53086415+juntaochi@users.noreply.github.com> Date: Fri, 29 May 2026 16:06:49 +0000 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Inline=20format=20duration?= =?UTF-8?q?=20in=20TUI=20update=20loop?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/ui/mod.rs | 34 ++++++++++++---------------------- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/src/ui/mod.rs b/src/ui/mod.rs index 6bbba9d..9345e70 100644 --- a/src/ui/mod.rs +++ b/src/ui/mod.rs @@ -9,7 +9,6 @@ use ratatui::{ }; use std::borrow::Cow; use std::sync::Arc; -use std::time::Duration; use tokio::task::JoinHandle; use crate::artwork::converter::ArtworkConverter; @@ -449,17 +448,19 @@ impl App { } else { 0 }; + // ⚡ Bolt Optimization: + // Inline time formatting to eliminate intermediate String allocations from helper functions. + // Avoids nested format! calls, speeding up the hot TUI update loop path. + let p_secs = track.position.as_secs(); + let d_secs = track.duration.as_secs(); cache.duration_str = format!( - "{} / {}", - format_duration(track.position), - format_duration(track.duration) - ); - cache.gauge_label = format!( - " {}/{} | {:02}% ", - format_duration_seconds(track.position), - format_duration_seconds(track.duration), - progress_percent + "{:02}:{:02} / {:02}:{:02}", + p_secs / 60, + p_secs % 60, + d_secs / 60, + d_secs % 60 ); + cache.gauge_label = format!(" {}s/{}s | {:02}% ", p_secs, d_secs, progress_percent); cache.progress_percent = progress_percent; self.metadata_cache = Some(cache); } else { @@ -1029,18 +1030,6 @@ pub fn draw(f: &mut Frame, app: &mut App) { } } -fn format_duration_seconds(duration: Duration) -> String { - let total_seconds = duration.as_secs(); - format!("{}s", total_seconds) -} - -fn format_duration(duration: Duration) -> String { - let total_seconds = duration.as_secs(); - let minutes = total_seconds / 60; - let seconds = total_seconds % 60; - format!("{:02}:{:02}", minutes, seconds) -} - // Optimized: Uses iterator chaining/cycling to avoid intermediate Vec and format! allocations. // Benchmark: ~32% speedup (329ms vs 484ms for 100k iters). fn scroll_text<'a>(text: &'a str, width: usize, frame: u32) -> Cow<'a, str> { @@ -1070,6 +1059,7 @@ mod tests { use async_trait::async_trait; use ratatui::backend::TestBackend; use ratatui::Terminal; + use std::time::Duration; struct MockPlayer { volume: u8,