Skip to content

Commit 82ee4b7

Browse files
andrii-idlqqq3coinspre-commit-ci[bot]JasonWeill
authored
Job Detail refactor (#60)
* remove output format, add grid * Parameter -> Parameter name * Parameter -> Parameter value * Change tag labels to 'Tag n' where n = idx + 1 * Adds idempotency token and tags for use in create job, details view (#56) * Adds idempotency token and tags for use in create job, details view Co-authored-by: Piyush Jain <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * remove height: 100% on the Box * remove unnecessary style * Idempotency token and Tags are passed as advanced options * adjust functional const names * populate state based on IJobDetailModel * update IJobDetailModel to include all fields displayed on Job Detail view * update Job Detail to render fields based on IJobDetail model * loading * roll back changes * fix control flow with additional useEffect on job?.jobName change (tbc if there is more optimal way) * map outputPath from dj.output_prefix not from dj.output_uri * add outputPrefix to JobDetailModel and object * pass output prefix of existing job to Create Job on rerun * change grid to stack * implement morbing into 1 column * render fields directly from Job Model * move useEffect below const declarations * fix how Parameters are displayed * use two-column stack for parameters. grid removed * change order of imports * comment out WIP output files * and time and status fields * Add links to ouput files * Update src/mainviews/job-detail.tsx Co-authored-by: Jason Weill <[email protected]> * Update src/mainviews/job-detail.tsx Co-authored-by: Jason Weill <[email protected]> * Update src/mainviews/job-detail.tsx Co-authored-by: Jason Weill <[email protected]> * await the execute call * move TextFieldStyled out of main function (JobDetail) scope * Define elements within the component vs separate subpomponents * make TextFields readonly instead of disabled * make Advanced Options input props readonly v disabled * display output file name, not just output format * Define logical parts of the component as elements within the large component v components within a component Co-authored-by: David L. Qiu <[email protected]> Co-authored-by: Piyush Jain <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jason Weill <[email protected]>
1 parent 0947134 commit 82ee4b7

File tree

3 files changed

+255
-238
lines changed

3 files changed

+255
-238
lines changed

src/advanced-options.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ const AdvancedOptions = (
109109
InputProps={{
110110
readOnly: true
111111
}}
112-
disabled
113112
/>
114113
))}
115114
</Stack>
@@ -129,7 +128,7 @@ const AdvancedOptions = (
129128
value={props.model.idempotencyToken}
130129
id={`${formPrefix}idempotencyToken`}
131130
name="idempotencyToken"
132-
disabled={props.jobsView !== 'CreateJob'}
131+
InputProps={{ readOnly: props.jobsView !== 'CreateJob' }}
133132
/>
134133
<FormLabel component="legend">{trans.__('Tags')}</FormLabel>
135134
{tagsDisplay}

0 commit comments

Comments
 (0)