Skip to content

Commit b39b3f7

Browse files
committed
add optional environment variables field to all models
1 parent 5d76259 commit b39b3f7

File tree

5 files changed

+14
-2
lines changed

5 files changed

+14
-2
lines changed

jupyter_scheduler/models.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ class CreateJob(BaseModel):
7777
input_filename: str = None
7878
runtime_environment_name: str
7979
runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
80+
environment_variables: Optional[Dict[str, str]] = None
8081
output_formats: Optional[List[str]] = None
8182
idempotency_token: Optional[str] = None
8283
job_definition_id: Optional[str] = None
@@ -128,6 +129,7 @@ class DescribeJob(BaseModel):
128129
input_filename: str = None
129130
runtime_environment_name: str
130131
runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
132+
environment_variables: Optional[Dict[str, str]] = None
131133
output_formats: Optional[List[str]] = None
132134
idempotency_token: Optional[str] = None
133135
job_definition_id: Optional[str] = None
@@ -193,6 +195,7 @@ class UpdateJob(BaseModel):
193195
status: Optional[Status] = None
194196
name: Optional[str] = None
195197
compute_type: Optional[str] = None
198+
environment_variables: Optional[Dict[str, str]] = None
196199

197200

198201
class DeleteJob(BaseModel):
@@ -204,6 +207,7 @@ class CreateJobDefinition(BaseModel):
204207
input_filename: str = None
205208
runtime_environment_name: str
206209
runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
210+
environment_variables: Optional[Dict[str, str]] = None
207211
output_formats: Optional[List[str]] = None
208212
parameters: Optional[Dict[str, str]] = None
209213
tags: Optional[Tags] = None
@@ -226,6 +230,7 @@ class DescribeJobDefinition(BaseModel):
226230
input_filename: str = None
227231
runtime_environment_name: str
228232
runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
233+
environment_variables: Optional[Dict[str, str]] = None
229234
output_formats: Optional[List[str]] = None
230235
parameters: Optional[Dict[str, str]] = None
231236
tags: Optional[Tags] = None
@@ -248,6 +253,7 @@ class Config:
248253
class UpdateJobDefinition(BaseModel):
249254
runtime_environment_name: Optional[str]
250255
runtime_environment_parameters: Optional[Dict[str, EnvironmentParameterValues]]
256+
environment_variables: Optional[Dict[str, str]] = None
251257
output_formats: Optional[List[str]] = None
252258
parameters: Optional[Dict[str, str]] = None
253259
tags: Optional[Tags] = None

jupyter_scheduler/orm.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ class CommonColumns:
8989
# Any default values specified for new columns will be ignored during the migration process.
9090
package_input_folder = Column(Boolean)
9191
packaged_files = Column(JsonType, default=[])
92+
environment_variables = Column(JsonType(4096))
9293

9394

9495
class Job(CommonColumns, Base):

src/handler.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ export namespace Scheduler {
364364
schedule?: string;
365365
timezone?: string;
366366
package_input_folder?: boolean;
367+
environment_variables?: { [key: string]: string };
367368
}
368369

369370
export interface IUpdateJobDefinition {
@@ -418,6 +419,7 @@ export namespace Scheduler {
418419
output_formats?: string[];
419420
compute_type?: string;
420421
package_input_folder?: boolean;
422+
environment_variables?: { [key: string]: string };
421423
}
422424

423425
export interface ICreateJobFromDefinition {

src/mainviews/create-job.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,8 @@ export function CreateJob(props: ICreateJobProps): JSX.Element {
322322
idempotency_token: props.model.idempotencyToken,
323323
tags: props.model.tags,
324324
runtime_environment_parameters: props.model.runtimeEnvironmentParameters,
325-
package_input_folder: props.model.packageInputFolder
325+
package_input_folder: props.model.packageInputFolder,
326+
environment_variables: props.model.environmentVariables
326327
};
327328

328329
if (props.model.parameters !== undefined) {
@@ -371,7 +372,8 @@ export function CreateJob(props: ICreateJobProps): JSX.Element {
371372
runtime_environment_parameters: props.model.runtimeEnvironmentParameters,
372373
schedule: props.model.schedule,
373374
timezone: props.model.timezone,
374-
package_input_folder: props.model.packageInputFolder
375+
package_input_folder: props.model.packageInputFolder,
376+
environment_variables: props.model.environmentVariables
375377
};
376378

377379
if (props.model.parameters !== undefined) {

src/model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export interface ICreateJobModel
100100
// Is the create button disabled due to a submission in progress?
101101
createInProgress?: boolean;
102102
packageInputFolder?: boolean;
103+
environmentVariables?: { [key: string]: string };
103104
}
104105

105106
export const defaultScheduleFields: ModelWithScheduleFields = {

0 commit comments

Comments
 (0)