Skip to content

ESC key and click outside modal do not stop exit tour. #58

@girdevstack

Description

@girdevstack

Description

When attempting to exit any tour using the esc key or clicking outside the modal, the tour continues on to the next step.

Reproduce

  1. Go to help menu
  2. Click on any tour
  3. Start tour
  4. Attempt to click outside of tour
  5. Attempt to exit tour using `esc key
  6. Attempt to close clicking "X" on window
    • Tour continues -

Expected behavior

When a user presses the esc key or clicks outside the tour, the tour should be exited and they should regain control of their notebook session instead of continuing the tour.

Context

Python 3.9.7
jupyter-client 7.1.1
jupyter-core 4.9.1
jupyterlab 3.2.8
jupyterlab-tour 3.1.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions