diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 20ca165..5a5f8f5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -66,7 +66,7 @@ jobs: # Ugh, I tried using matrix or something to explicitly generate only test pypi or prod pypi pipelines. # But github actions is so shit, it's impossible to do any logic at all, e.g. doesn't support conditional matrix, if/else statements for variables etc. - needs: [build] # add all other jobs here + needs: [build, end2end_tests] # add all other jobs here runs-on: ubuntu-latest diff --git a/extension/generate_manifest.js b/extension/generate_manifest.js index bb70fbf..1fd0729 100644 --- a/extension/generate_manifest.js +++ b/extension/generate_manifest.js @@ -114,6 +114,8 @@ export function generateManifest({ version: pkg.version, description: pkg.description, permissions: permissions, + // Firefox for Android does not support extension keyboard shortcuts. + // https://bugzilla.mozilla.org/show_bug.cgi?id=1584246 commands: commands, optional_permissions: optional_permissions, manifest_version: v3 ? 3 : 2, diff --git a/extension/package.json b/extension/package.json index 4e7aaaf..84edbd3 100644 --- a/extension/package.json +++ b/extension/package.json @@ -3,7 +3,6 @@ "version": "1.0.2.2", "version_name": "released on 2026.01.20", "description": "Reliably capture links and webpage content in a plaintext file (org-mode/markdown)", - "main": "dist/background.js", "scripts": { "test": "jest", "build": "rollup --config", diff --git a/extension/rollup.config.js b/extension/rollup.config.js index 3681781..10fc930 100644 --- a/extension/rollup.config.js +++ b/extension/rollup.config.js @@ -74,8 +74,13 @@ const compile = inputs => { return { // huh! so if I build all files in one go, it figures out the shared files properly it seems // however it still inlines webextension stuff into one of the files? e.g. common manualChunks: id => { // ugh, seems a bit shit? - if (id.includes('webextension-polyfill')) { - return 'webextension-polyfill' // move it in a separate chunk + const third_party = [ + 'webextension-polyfill', + ] + for (const x of third_party) { + if (id.includes(x)) { + return `third_party/${x}` // move it in a separate chunk + } } }, },