Repository navigation
Complete Kernel-managed Visa card checkout in CLI - #283
Open
hiroTamada wants to merge 4 commits into
Open
hiroTamada wants to merge 4 commits into
hiroTamada wants to merge 4 commits into
Conversation
hiroTamada
marked this pull request as ready for review
October 12, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
confirm_transactionthrough--paramsor--spec-file, validating required fields, enums, integer amounts, uppercase currency, RFC3339 timestamps, and unknown/duplicate properties before any request; send the exact JSON body without automatic retriesrestart_verification --openinrecovery_required; hide and refuse all other operations even when advertised, retain the original refusal unless restart is advertised, and suppress stale recovery action URLscompatibility
restart_verificationdepends on kernel/kernel#4760, currently deployed only to staging; availability is always gated onavailable_operationsconfirm_transactionorrestart_verificationrequest types. confirmation usesoption.WithRequestBodywith validated JSON andoption.WithMaxRetries(0); replace the raw body with the typed parameter once the SDK is regenerated. restart uses the existing advertised parameterless-operation path.validation
make testpassed (go vet ./...andgo test ./...)make lintcompleted successfully, but the repository's recipe masks lint failures: the full run reports 72 existing warnings (main reports 74); no unrelated lint cleanup includedgolangci-lint run --new-from-rev=origin/mainpassed with 0 issuesmake buildand built-binary wallet/card/invoke--helpchecks passed--open, three-field Kernel fill, card-data rejection, and updated guidance/examplesNote
High Risk
Changes payment credential flows, recovery behavior, and outcome reporting—mistakes could cause duplicate charges, wrong reconciliation, or unsafe handling of card data.
Overview
Adds Kernel-managed vault payments to the CLI:
kernelwallets/cards,vaults wallets get, hosted enrollment, token-eligibility guidance, browser fill for ready Kernel cards (no stored billing; origin locked tomerchant_url), and blocking card PAN/CVC/expiry in--spec.Introduces
confirm_transactionvia--params/--spec-filewith strict local validation and a raw JSON POST (no retries) until the SDK exposes the operation type.Tightens
recovery_required: only an advertised, parameterlessrestart_verification(optional--open) may run; other operations stay blocked with updated errors and human guidance. README and command help document the full Kernel checkout flow (authorize → fill → one-time outcome report).Reviewed by Cursor Bugbot for commit a18d8a8. Bugbot is set up for automated code reviews on this repo. Configure here.